Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 947993003: Chromecast: disables wifi-based features on ATV. (Closed)

Created:
5 years, 10 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: disables wifi-based features on ATV. R=lcwu@chromium.org,byungchul@chromium.org BUG=internal b/18934906 Committed: https://crrev.com/dc4666755b0408c2ec6eba26211a77ca502ff9e6 Cr-Commit-Position: refs/heads/master@{#317683}

Patch Set 1 #

Total comments: 3

Patch Set 2 : adds comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test_runner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/common/chromecast_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromecast/common/chromecast_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
gunsch
5 years, 10 months ago (2015-02-23 18:52:36 UTC) #1
lcwu1
lgtm % a suggestion in additional comment https://codereview.chromium.org/947993003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/947993003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode104 chromecast/browser/cast_browser_main_parts.cc:104: { switches::kNoWifi, ...
5 years, 10 months ago (2015-02-23 21:48:50 UTC) #2
gunsch
https://codereview.chromium.org/947993003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/947993003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode104 chromecast/browser/cast_browser_main_parts.cc:104: { switches::kNoWifi, "" }, On 2015/02/23 21:48:50, lcwu1 wrote: ...
5 years, 10 months ago (2015-02-23 22:00:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947993003/20001
5 years, 10 months ago (2015-02-23 22:01:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 00:08:14 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:08:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc4666755b0408c2ec6eba26211a77ca502ff9e6
Cr-Commit-Position: refs/heads/master@{#317683}

Powered by Google App Engine
This is Rietveld 408576698