Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 947983002: Move zoom handling for x and y properties to svg (Closed)

Created:
5 years, 10 months ago by Erik Dahlström (inactive)
Modified:
5 years, 10 months ago
Reviewers:
fs
CC:
blink-reviews, shans, rjwright, blink-reviews-style_chromium.org, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, ed+blinkwatch_opera.com, Timothy Loh, dstockwell, dglazkov+blink, Steve Block, apavlov+blink_chromium.org, darktears, Eric Willigers, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move zoom handling for x and y properties to svg. Compensating for effectiveZoom in svg instead, so that x and y are more like other length values in css. This fixes a bug where incorrect values would be returned from getComputedStyle, and with transitions on x and y in combination with zoom. BUG=400725 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190836

Patch Set 1 #

Patch Set 2 : handle zoom in SVGLengthContext #

Patch Set 3 : rebase + remove unused methods #

Patch Set 4 : add zoom transition testcase + test fix #

Patch Set 5 : oops #

Patch Set 6 : rebase + add NeedsRebaseline #

Total comments: 2

Patch Set 7 : pass in LayoutStyle #

Total comments: 2

Patch Set 8 : move function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -22 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/zoom/xy-getcomputedstyle.html View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/transitions/svg-layout-transition-zoom.html View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
A + LayoutTests/transitions/svg-layout-transition-zoom-expected.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGRect.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGPathData.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLengthContext.h View 1 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 2 3 4 5 6 7 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Dahlström (inactive)
5 years, 10 months ago (2015-02-24 17:12:34 UTC) #2
fs
https://codereview.chromium.org/947983002/diff/100001/Source/core/svg/SVGLengthContext.cpp File Source/core/svg/SVGLengthContext.cpp (right): https://codereview.chromium.org/947983002/diff/100001/Source/core/svg/SVGLengthContext.cpp#newcode118 Source/core/svg/SVGLengthContext.cpp:118: LayoutStyle* style = layoutStyleForLengthResolving(m_context); Should rather be passing a ...
5 years, 10 months ago (2015-02-24 17:29:28 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/947983002/diff/100001/Source/core/svg/SVGLengthContext.cpp File Source/core/svg/SVGLengthContext.cpp (right): https://codereview.chromium.org/947983002/diff/100001/Source/core/svg/SVGLengthContext.cpp#newcode118 Source/core/svg/SVGLengthContext.cpp:118: LayoutStyle* style = layoutStyleForLengthResolving(m_context); On 2015/02/24 17:29:28, fs wrote: ...
5 years, 10 months ago (2015-02-25 09:17:36 UTC) #4
fs
lgtm https://codereview.chromium.org/947983002/diff/120001/Source/core/svg/SVGLengthContext.cpp File Source/core/svg/SVGLengthContext.cpp (right): https://codereview.chromium.org/947983002/diff/120001/Source/core/svg/SVGLengthContext.cpp#newcode99 Source/core/svg/SVGLengthContext.cpp:99: static inline LayoutStyle* layoutStyleForLengthResolving(const SVGElement* context) Please restore ...
5 years, 10 months ago (2015-02-25 13:43:11 UTC) #5
Erik Dahlström (inactive)
https://codereview.chromium.org/947983002/diff/120001/Source/core/svg/SVGLengthContext.cpp File Source/core/svg/SVGLengthContext.cpp (right): https://codereview.chromium.org/947983002/diff/120001/Source/core/svg/SVGLengthContext.cpp#newcode99 Source/core/svg/SVGLengthContext.cpp:99: static inline LayoutStyle* layoutStyleForLengthResolving(const SVGElement* context) On 2015/02/25 13:43:11, ...
5 years, 10 months ago (2015-02-25 13:54:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947983002/140001
5 years, 10 months ago (2015-02-25 13:55:20 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:12:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190836

Powered by Google App Engine
This is Rietveld 408576698