Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 947963002: [turbofan] Initial version of branch cloning. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial version of branch cloning. This implements a special case of block cloning to recognize constructs like if (a ? b : c) { ... } that happen to be generated by Emscripten quite often. Committed: https://crrev.com/0882d3ff81d460717cb04670378b92ce0444ce80 Cr-Commit-Position: refs/heads/master@{#26808}

Patch Set 1 #

Patch Set 2 : Tests and documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -5 lines) Patch
M src/compiler/control-flow-optimizer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/control-flow-optimizer.cc View 1 2 chunks +151 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/asm/if-cloning.js View 1 1 chunk +34 lines, -0 lines 0 comments Download
M test/unittests/compiler/control-flow-optimizer-unittest.cc View 1 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-24 07:10:04 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-24 07:39:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947963002/20001
5 years, 10 months ago (2015-02-24 07:40:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947963002/20001
5 years, 10 months ago (2015-02-24 07:40:38 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-24 07:41:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 07:41:33 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 07:41:44 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0882d3ff81d460717cb04670378b92ce0444ce80
Cr-Commit-Position: refs/heads/master@{#26808}

Powered by Google App Engine
This is Rietveld 408576698