Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 947953003: ServiceWorker: Add running service worker check before claim a provider host. (Closed)

Created:
5 years, 10 months ago by xiang
Modified:
5 years, 10 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Add running service worker check before claim a provider host. A provider host which hosts a running service worker has its document URL set to the script's URL now. So check it explicitly to avoid DCHECK fail. BUG=459244 Committed: https://crrev.com/d565971b03e3414d6a43ac2fef95d88a0b65de55 Cr-Commit-Position: refs/heads/master@{#317988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_registration.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xiang
PTAL, thanks. I'm not sure whether a layout test is needed or not?
5 years, 10 months ago (2015-02-25 02:45:34 UTC) #2
falken
On 2015/02/25 02:45:34, xiang wrote: > PTAL, thanks. > I'm not sure whether a layout ...
5 years, 10 months ago (2015-02-25 03:21:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947953003/1
5 years, 10 months ago (2015-02-25 04:50:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 05:49:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 05:49:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d565971b03e3414d6a43ac2fef95d88a0b65de55
Cr-Commit-Position: refs/heads/master@{#317988}

Powered by Google App Engine
This is Rietveld 408576698