Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 947933004: move static init to cpp file to fix linux builder (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move static init to cpp file to fix linux builder TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/9ece6a95481c3226b4519c8e9f685eb3fc1873b3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M include/gpu/GrClip.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrClip.cpp View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947933004/1
5 years, 10 months ago (2015-02-24 00:58:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9ece6a95481c3226b4519c8e9f685eb3fc1873b3
5 years, 10 months ago (2015-02-24 01:03:36 UTC) #5
bsalomon
https://codereview.chromium.org/947933004/diff/1/src/gpu/GrClip.cpp File src/gpu/GrClip.cpp (right): https://codereview.chromium.org/947933004/diff/1/src/gpu/GrClip.cpp#newcode53 src/gpu/GrClip.cpp:53: static GrClip clip; probably should be const. lgtm
5 years, 10 months ago (2015-02-24 13:29:19 UTC) #7
mtklein
5 years, 10 months ago (2015-02-24 13:41:25 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/947933004/diff/1/src/gpu/GrClip.cpp
File src/gpu/GrClip.cpp (right):

https://codereview.chromium.org/947933004/diff/1/src/gpu/GrClip.cpp#newcode53
src/gpu/GrClip.cpp:53: static GrClip clip;
Yep.  And please keep in mind that local statics like this are not always
initialized in a thread-safe way.  (MSVC doesn't do it, and Chromium disables it
even when supported in GCC / Clang.)

Powered by Google App Engine
This is Rietveld 408576698