Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 94793003: Fix compilation error with latest Xcode. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
7 years ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Fix compilation error with latest Xcode. The build failed because of unused private fields. R=titzer@chromium.org BUG=v8:3030 LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18171

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/hydrogen-check-elimination.h View 3 chunks +15 lines, -11 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years ago (2013-12-01 06:38:16 UTC) #1
titzer
On 2013/12/01 06:38:16, Benedikt Meurer wrote: > PTAL LGTM
7 years ago (2013-12-02 08:08:01 UTC) #2
Benedikt Meurer
7 years ago (2013-12-02 08:09:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698