ui/app_list/views/contents_view.h - Issue 947903002: Change ContentsView::SetActivePage to use States rather than indexes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/contents_view.h

Issue 947903002: Change ContentsView::SetActivePage to use States rather than indexes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/contents_view.h

diff --git a/ui/app_list/views/contents_view.h b/ui/app_list/views/contents_view.h

index 89d8d6973f048f40ee96a7f9d1f2494f290ff429..7da3481779875140b88e2f1648c192a7a7ff9c04 100644

--- a/ui/app_list/views/contents_view.h

+++ b/ui/app_list/views/contents_view.h

@@ -70,8 +70,8 @@ class APP_LIST_EXPORT ContentsView : public views::View,

void ShowFolderContent(AppListFolderItem* folder);

// Sets the active launcher page and animates the pages into place.

- void SetActivePage(int page_index);

- void SetActivePage(int page_index, bool animate);

+ void SetActivePage(AppListModel::State state);

Matt Giuca 2015/02/23 23:57:27 I think this should be renamed to SetActiveState.

calamity 2015/02/24 06:40:24 Done.

+ void SetActivePage(AppListModel::State state, bool animate);

// The index of the currently active launcher page.

int GetActivePageIndex() const;

« no previous file with comments | « ui/app_list/views/app_list_view_unittest.cc ('k') | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »