Source/core/svg/graphics/SVGImage.cpp - Issue 947893002: Implement SVG masking with slimming paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/graphics/SVGImage.cpp

Issue 947893002: Implement SVG masking with slimming paint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove spurious change Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/CompositingRecorder.h ('K') | « Source/core/paint/SVGPaintContext.cpp ('k') | Source/platform/graphics/GraphicsContext.h » ('j') | Source/platform/graphics/paint/DrawingDisplayItem.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/graphics/SVGImage.cpp

diff --git a/Source/core/svg/graphics/SVGImage.cpp b/Source/core/svg/graphics/SVGImage.cpp

index 2aae7d2f51fed8f4fd378bacfd49e49822290095..64d43f98b4faa69896233305f6c0a4a4917cf1dc 100644

--- a/Source/core/svg/graphics/SVGImage.cpp

+++ b/Source/core/svg/graphics/SVGImage.cpp

@@ -289,7 +289,7 @@ void SVGImage::draw(GraphicsContext* context, const FloatRect& dstRect, const Fl

bool hasCompositing = compositeOp != SkXfermode::kSrcOver_Mode;

OwnPtr<CompositingRecorder> compositingRecorder;

if (hasCompositing || opacity < 1)

- compositingRecorder = adoptPtr(new CompositingRecorder(&recordingContext, displayItemClient(), compositeOperatorFromSkia(compositeOp), blendModeFromSkia(compositeOp), opacity));

+ compositingRecorder = adoptPtr(new CompositingRecorder(&recordingContext, displayItemClient(), compositeOp, opacity));

// We can only draw the entire frame, clipped to the rect we want. So compute where the top left

// of the image would be if we were drawing without clipping, and translate accordingly.