Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 947873002: Revert of Check for an active document in WebPluginContainerImpl::windowClipRect (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
esprehn, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Check for an active document in WebPluginContainerImpl::windowClipRect (patchset #1 id:1 of https://codereview.chromium.org/944753004/) Reason for revert: This did not fix the crash but it gave us enough info to fix this (in a followup). Original issue's description: > Check for an active document in WebPluginContainerImpl::windowClipRect > > This is a speculative fix for crbug.com/459713. The exact cause is not > clear in our crash reports but this change may fix an issue where the > document is being destroyed. A Document's m_frame is only reset > during destruction, after the lifecycle is set to be not active, so > this patch adds a check for isActive. Additionally, this patch will > move the crash location if the node's renderer is null. > > BUG=459713 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190582 TBR=eae@chromium.org,esprehn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459713, 460821 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
Created Revert of Check for an active document in WebPluginContainerImpl::windowClipRect
5 years, 10 months ago (2015-02-23 03:35:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947873002/1
5 years, 10 months ago (2015-02-23 03:35:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190633
5 years, 10 months ago (2015-02-23 03:35:36 UTC) #3
eae
5 years, 10 months ago (2015-02-23 18:40:12 UTC) #4
Message was sent while issue was closed.
LGTM (post facto)

Powered by Google App Engine
This is Rietveld 408576698