Sync the DOMTokenList interface with the spec

Sync the DOMTokenList interface with the spec

https://dom.spec.whatwg.org/#interface-domtokenlist

BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190649

[philipj_slow, 2015-02-22 16:44:53]

philipj@opera.com changed reviewers:
+ haraken@chromium.org

[philipj_slow, 2015-02-22 16:44:54]

PTAL

[haraken, 2015-02-23 03:29:27]

haraken@chromium.org changed reviewers:
+ jl@opera.com

[haraken, 2015-02-23 03:29:28]

LGTM

> Replacing [TreatReturnedNullStringAs=Null] with DOMString? does not change the
generated code.

I think this is fine, but Jens should confirm.

[Jens Widell, 2015-02-23 07:09:49]

LGTM

No changes in generated code, and DOMString? is certainly prefered over a
non-standard extended attribute.

[haraken, 2015-02-23 07:45:27]

> No changes in generated code, and DOMString? is certainly prefered over a
> non-standard extended attribute.

Can we remove [TreatReturnedNullStringAs=Null] entirely from our IDL files?

[Jens Widell, 2015-02-23 07:48:40]

On 2015/02/23 07:45:27, haraken wrote:
> > No changes in generated code, and DOMString? is certainly prefered over a
> > non-standard extended attribute.
> 
> Can we remove [TreatReturnedNullStringAs=Null] entirely from our IDL files?

I should think so. It's certainly technically possible, and I can't think of any
good reason not to.

[philipj_slow, 2015-02-23 07:50:07]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-02-23 07:50:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947833002/1

[philipj_slow, 2015-02-23 07:51:43]

There aren't many occurrences of it left, two similar getters on
MediaList/DOMSettableTokenList and Node.textContent.

[philipj_slow, 2015-02-23 07:53:17]

On 2015/02/23 07:51:43, philipj_UTC7 wrote:
> There aren't many occurrences of it left, two similar getters on
> MediaList/DOMSettableTokenList and Node.textContent.

In other words, I'll prepare a CL.

[philipj_slow, 2015-02-23 07:53:34]

The CQ bit was unchecked by philipj@opera.com

[philipj_slow, 2015-02-23 08:05:23]

https://codereview.chromium.org/950763002/

I'll wait to land that CL before this one to deal with this in a single commit.

[philipj_slow, 2015-02-23 09:48:48]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-02-23 09:49:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947833002/1

[commit-bot: I haz the power, 2015-02-23 09:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 09:49:36]

Failed to apply patch for Source/core/dom/DOMTokenList.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/DOMTokenList.idl
  Hunk #1 FAILED at 23.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/DOMTokenList.idl.rej

Patch:       Source/core/dom/DOMTokenList.idl
Index: Source/core/dom/DOMTokenList.idl
diff --git a/Source/core/dom/DOMTokenList.idl b/Source/core/dom/DOMTokenList.idl
index
766ca9444d1dff74100b428249add0a91bcd01fe..1293203c498ea8096609ea9927926222f1174fb6
100644
--- a/Source/core/dom/DOMTokenList.idl
+++ b/Source/core/dom/DOMTokenList.idl
@@ -23,17 +23,18 @@
  */
 
 // https://dom.spec.whatwg.org/#interface-domtokenlist
+
 [
     SetWrapperReferenceFrom=element,
     WillBeGarbageCollected,
 ] interface DOMTokenList {
     readonly attribute unsigned long length;
-    [TreatReturnedNullStringAs=Null] getter DOMString item(unsigned long
index);
+    getter DOMString? item(unsigned long index);
     [RaisesException] boolean contains(DOMString token);
     [RaisesException, CustomElementCallbacks] void add(DOMString... tokens);
     [RaisesException, CustomElementCallbacks] void remove(DOMString... tokens);
     [RaisesException, CustomElementCallbacks] boolean toggle(DOMString token,
optional boolean force);
-
+    // FIXME: stringifier should be enumerable.
     [NotEnumerable] stringifier;
     iterable<DOMString>;
 };

[philipj_slow, 2015-02-23 10:24:13]

New patchsets have been uploaded after l-g-t-m from
haraken@chromium.org,jl@opera.com

[philipj_slow, 2015-02-23 10:24:16]

rebase

[philipj_slow, 2015-02-23 10:24:23]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-02-23 10:24:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947833002/20001

[commit-bot: I haz the power, 2015-02-23 11:45:43]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190649