Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 947743002: content: Fix problem with implementation of MergeIntoFreeList. (Closed)

Created:
5 years, 10 months ago by reveman
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Fix problem with implementation of MergeIntoFreeList. When merging span with previous span, the start of span should only be removed if the start doesn't also represent the end of span. BUG=429416 TEST=content_unittests --gtest_filter=DiscardableSharedMemoryHeapTest.MergeSingleBlockSpan Committed: https://crrev.com/6349d624ac8853f0eb106510835fb0cd17850534 Cr-Commit-Position: refs/heads/master@{#317516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M content/common/discardable_shared_memory_heap.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/discardable_shared_memory_heap_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
5 years, 10 months ago (2015-02-21 18:50:00 UTC) #2
Avi (use Gerrit)
lgtm ok
5 years, 10 months ago (2015-02-21 20:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947743002/1
5 years, 10 months ago (2015-02-21 20:30:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-21 20:38:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 20:39:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6349d624ac8853f0eb106510835fb0cd17850534
Cr-Commit-Position: refs/heads/master@{#317516}

Powered by Google App Engine
This is Rietveld 408576698