Issue 9477: Continue with crosssite navigations if alerts are suppressed...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9477: Continue with crosssite navigations if alerts are suppressed... (Closed)

Created:
12 years, 1 month ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Continue with crosssite navigations if alerts are suppressed in an unload handler (i.e. we have an infinite-ish alert loop). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4935

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -7 lines)			Patch
M	chrome/browser/render_view_host.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/render_view_host.cc	View	3 chunks	+12 lines, -4 lines	1 comment	Download
M	chrome/browser/render_view_host_delegate.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/web_contents.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/web_contents.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

12 years, 1 month ago (2008-11-07 00:00:45 UTC) #2

LGTM

http://codereview.chromium.org/9477/diff/1/2
File chrome/browser/render_view_host.cc (right):

http://codereview.chromium.org/9477/diff/1/2#newcode485
Line 485: } else {
nit: no need for else after return.  alternatively, you could drop the return
here.

Expand Messages | Collapse Messages