src/x64/code-stubs-x64.cc - Issue 947683002: Reimplement Maps and Sets in JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 947683002: Reimplement Maps and Sets in JS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rename all the things, add more macros, and remove unnecessary %_CallFunctions Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 99196da425442eefd18fb735e54a97f554848e22..ccde2cc74218cfb007a50e53d57e9f25c7524639 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -2455,16 +2455,6 @@ void CEntryStub::Generate(MacroAssembler* masm) {

}

#endif // _WIN64

- // Runtime functions should not return 'the hole'. Allowing it to escape may

- // lead to crashes in the IC code later.

- if (FLAG_debug_code) {

- Label okay;

- __ CompareRoot(rax, Heap::kTheHoleValueRootIndex);

- __ j(not_equal, &okay, Label::kNear);

- __ int3();

- __ bind(&okay);

- }

// Check result for exception sentinel.

Label exception_returned;

__ CompareRoot(rax, Heap::kExceptionRootIndex);