Reimplement Maps and Sets in JS

src/harmony-templates.js

Index: src/harmony-templates.js
diff --git a/src/harmony-templates.js b/src/harmony-templates.js
index 254f434fdfe0e6eb75a268b8774c6fa7a49b261e..fa89a849f4f93760d8f498c11c624a4a4ab8fe58 100644
--- a/src/harmony-templates.js
+++ b/src/harmony-templates.js
@@ -21,7 +21,7 @@ function SameCallSiteElements(rawStrings, other) {
 
 
 function GetCachedCallSite(siteObj, hash) {
-  var obj = %MapGet(callSiteCache, hash);
+  var obj = %_CallFunction(callSiteCache, hash, $MapGet);

[caitp (gmail), 2015/03/25 12:56:27]

Couldn't we just call MapGet() (and others) directly here?

[adamk, 2015/03/25 15:43:06]

MapGet is now inside a closure, so it's not visible here.

[caitp (gmail), 2015/03/25 15:46:24]

I mean, you have a reference to $MapGet, otherwise %_CallFunction() wouldn't
work either.

[adamk, 2015/03/25 16:13:36]

Not sure what you're saying. I could have called "$MapGet" "MapGet" instead, but
$MapGet seemed a little clearer to me.

[adamk, 2015/03/25 16:14:24]

Or are you asking about the use of %_CallFunction()? That's necessary because
MapGet expects its first argument to be in |this|.

[caitp (gmail), 2015/03/25 16:31:50]

OH --- derp, you're right. Course, this map here is private, so $MapGet could be
assigned to the map instance --- anyway, do it how you want to do it

 
   if (IS_UNDEFINED(obj)) return;
 
@@ -33,13 +33,13 @@ function GetCachedCallSite(siteObj, hash) {
 
 
 function SetCachedCallSite(siteObj, hash) {
-  var obj = %MapGet(callSiteCache, hash);
+  var obj = %_CallFunction(callSiteCache, hash, $MapGet);
   var array;
 
   if (IS_UNDEFINED(obj)) {
     array = new InternalArray(1);
     array[0] = siteObj;
-    %MapSet(callSiteCache, hash, array);
+    %_CallFunction(callSiteCache, hash, array, $MapSet);
   } else {
     obj.push(siteObj);
   }