Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: test/cctest/test-dictionary.cc

Issue 947683002: Reimplement Maps and Sets in JS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Moved more to JS Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 CHECK_EQ(identity_hash, CcTest::heap()->undefined_value()); 103 CHECK_EQ(identity_hash, CcTest::heap()->undefined_value());
104 } 104 }
105 } 105 }
106 106
107 107
108 TEST(HashMap) { 108 TEST(HashMap) {
109 LocalContext context; 109 LocalContext context;
110 v8::HandleScope scope(context->GetIsolate()); 110 v8::HandleScope scope(context->GetIsolate());
111 Isolate* isolate = CcTest::i_isolate(); 111 Isolate* isolate = CcTest::i_isolate();
112 TestHashMap(ObjectHashTable::New(isolate, 23)); 112 TestHashMap(ObjectHashTable::New(isolate, 23));
113 TestHashMap(isolate->factory()->NewOrderedHashMap()); 113 //TestHashMap(isolate->factory()->NewOrderedHashMap());
114 } 114 }
115 115
116 116
117 class ObjectHashTableTest: public ObjectHashTable { 117 class ObjectHashTableTest: public ObjectHashTable {
118 public: 118 public:
119 void insert(int entry, int key, int value) { 119 void insert(int entry, int key, int value) {
120 set(EntryToIndex(entry), Smi::FromInt(key)); 120 set(EntryToIndex(entry), Smi::FromInt(key));
121 set(EntryToIndex(entry) + 1, Smi::FromInt(value)); 121 set(EntryToIndex(entry) + 1, Smi::FromInt(value));
122 } 122 }
123 123
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 table = HashSet::Remove(table, key, &was_present); 194 table = HashSet::Remove(table, key, &was_present);
195 CHECK(!was_present); 195 CHECK(!was_present);
196 CHECK(gc_count == isolate->heap()->gc_count()); 196 CHECK(gc_count == isolate->heap()->gc_count());
197 197
198 // Calling Add() should cause GC. 198 // Calling Add() should cause GC.
199 table = HashSet::Add(table, key); 199 table = HashSet::Add(table, key);
200 CHECK(gc_count < isolate->heap()->gc_count()); 200 CHECK(gc_count < isolate->heap()->gc_count());
201 } 201 }
202 202
203 203
204 /*
204 TEST(ObjectHashSetCausesGC) { 205 TEST(ObjectHashSetCausesGC) {
205 i::FLAG_stress_compaction = false; 206 i::FLAG_stress_compaction = false;
206 LocalContext context; 207 LocalContext context;
207 v8::HandleScope scope(context->GetIsolate()); 208 v8::HandleScope scope(context->GetIsolate());
208 Isolate* isolate = CcTest::i_isolate(); 209 Isolate* isolate = CcTest::i_isolate();
209 TestHashSetCausesGC(isolate->factory()->NewOrderedHashSet()); 210 TestHashSetCausesGC(isolate->factory()->NewOrderedHashSet());
210 } 211 }
212 */
211 #endif 213 #endif
212 214
213 215
214 #ifdef DEBUG 216 #ifdef DEBUG
215 template<class HashMap> 217 template<class HashMap>
216 static void TestHashMapCausesGC(Handle<HashMap> table) { 218 static void TestHashMapCausesGC(Handle<HashMap> table) {
217 Isolate* isolate = CcTest::i_isolate(); 219 Isolate* isolate = CcTest::i_isolate();
218 Factory* factory = isolate->factory(); 220 Factory* factory = isolate->factory();
219 221
220 Handle<JSObject> key = factory->NewJSArray(0); 222 Handle<JSObject> key = factory->NewJSArray(0);
(...skipping 18 matching lines...) Expand all
239 CHECK(gc_count < isolate->heap()->gc_count()); 241 CHECK(gc_count < isolate->heap()->gc_count());
240 } 242 }
241 243
242 244
243 TEST(ObjectHashTableCausesGC) { 245 TEST(ObjectHashTableCausesGC) {
244 i::FLAG_stress_compaction = false; 246 i::FLAG_stress_compaction = false;
245 LocalContext context; 247 LocalContext context;
246 v8::HandleScope scope(context->GetIsolate()); 248 v8::HandleScope scope(context->GetIsolate());
247 Isolate* isolate = CcTest::i_isolate(); 249 Isolate* isolate = CcTest::i_isolate();
248 TestHashMapCausesGC(ObjectHashTable::New(isolate, 1)); 250 TestHashMapCausesGC(ObjectHashTable::New(isolate, 1));
249 TestHashMapCausesGC(isolate->factory()->NewOrderedHashMap()); 251 //TestHashMapCausesGC(isolate->factory()->NewOrderedHashMap());
250 } 252 }
251 #endif 253 #endif
252 254
253
254 } 255 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698