Get more useful LOG(FATAL) messages from ExtensionSyncData to help diagnose crashes.

Get more useful LOG(FATAL) messages from ExtensionSyncData to help diagnose crashes.

BUG=359210
Committed: https://crrev.com/768503cd5548895a72fd8fe5579032403175b8c9
Cr-Commit-Position: refs/heads/master@{#317751}

[Yoyo Zhou, 2015-02-21 01:37:10]

yoz@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2015-02-21 17:33:35]

lgtm with comment.

Also, FYI, Rietveld still has your OOO message. :)

https://codereview.chromium.org/947673002/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_sync_data.cc (right):

https://codereview.chromium.org/947673002/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_sync_data.cc:100: << specifics.id() << ".";
If it was me, I'd probably make a LogExtensionSpecifics() method that printed
out the id, version, update url, and name.  I'm just thinking that if we find a
bad extension id, that in and of itself may not help much (though it may).

[Yoyo Zhou, 2015-02-23 20:59:36]

More detail now. (Also fixed my OOO message, thanks.)

I agree that if we have corrupted data, then we probably need more detail - I'm
imagining that we get empty extension IDs, so it would help to know if every
other field is empty too.

[Yoyo Zhou, 2015-02-23 20:59:41]

The CQ bit was checked by yoz@chromium.org

[Yoyo Zhou, 2015-02-23 20:59:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/947673002/#ps20001
(title: "moar detail")

[commit-bot: I haz the power, 2015-02-23 21:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947673002/20001

[commit-bot: I haz the power, 2015-02-23 23:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:48:34]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoyo Zhou, 2015-02-24 02:34:28]

I switched to StringPrintf since Mac clang doesn't seem to like the brace
initializer for vectors.

[Yoyo Zhou, 2015-02-24 02:34:32]

The CQ bit was checked by yoz@chromium.org

[Yoyo Zhou, 2015-02-24 02:34:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/947673002/#ps40001 (title:
"stringprintf")

[commit-bot: I haz the power, 2015-02-24 02:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947673002/40001

[commit-bot: I haz the power, 2015-02-24 03:40:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-24 03:41:06]

Patchset 3 (id:??) landed as
https://crrev.com/768503cd5548895a72fd8fe5579032403175b8c9
Cr-Commit-Position: refs/heads/master@{#317751}