components/device_event_log/device_event_log_impl.cc - Issue 947663002: Log device/hid messages to chrome://device-log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/device_event_log/device_event_log_impl.cc

Issue 947663002: Log device/hid messages to chrome://device-log. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarified destructor behavior, cleaned up OS X error logging. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/device_event_log/device_event_log_impl.cc

diff --git a/components/device_event_log/device_event_log_impl.cc b/components/device_event_log/device_event_log_impl.cc

index 766ed16c73397ab20c201816565996248d5b5f6f..3d7b8862b49eb2480a09f6e9bc7da77946f27a5f 100644

--- a/components/device_event_log/device_event_log_impl.cc

+++ b/components/device_event_log/device_event_log_impl.cc

@@ -30,6 +30,7 @@ const char* kLogTypeNetworkDesc = "Network";

const char* kLogTypePowerDesc = "Power";

const char* kLogTypeLoginDesc = "Login";

const char* kLogTypeUsbDesc = "USB";

+const char* kLogTypeHidDesc = "HID";

std::string GetLogTypeString(LogType type) {

switch (type) {

@@ -41,6 +42,8 @@ std::string GetLogTypeString(LogType type) {

return kLogTypeLoginDesc;

case LOG_TYPE_USB:

return kLogTypeUsbDesc;

+ case LOG_TYPE_HID:

+ return kLogTypeHidDesc;

default:

NOTREACHED();

return "Unknown";