Log device/hid messages to chrome://device-log.

Log device/hid messages to chrome://device-log.

Log events and debugging information related to HID devices through the
device event log component so that these errors are visible at
chrome://device-log. A DEVICE_PLOG macro has been added which includes
the last reported system error in the log message.

BUG=448901
Committed: https://crrev.com/b9da284b42d4a3b9498d64f1c61452c5f5ae4ff2
Cr-Commit-Position: refs/heads/master@{#317722}

[Reilly Grant (use Gerrit), 2015-02-23 20:45:24]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2015-02-23 21:05:15]

reillyg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Reilly Grant (use Gerrit), 2015-02-23 21:05:15]

This adds similar logging for device/hid. The interesting part here is the new
DEVICE_PLOG macro. Please take a look.

[stevenjb, 2015-02-23 21:45:29]

Please have someone familiar with the HID code review this also.

https://codereview.chromium.org/947663002/diff/20001/chrome/app/chromium_stri...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/947663002/diff/20001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1356: <message name="IDS_DEVICE_LOG_TYPE_HID"
desc="Checkbox to enable showing events of type HID">
Please explain 'HID' in the comment, I don't think it is as well known as, say,
USB.

https://codereview.chromium.org/947663002/diff/20001/components/device_event_...
File components/device_event_log/device_event_log.h (right):

https://codereview.chromium.org/947663002/diff/20001/components/device_event_...
components/device_event_log/device_event_log.h:172: // Implementation class for
DEVICE_PLOG macros. Provides a stream for createing
creating

https://codereview.chromium.org/947663002/diff/20001/components/device_event_...
components/device_event_log/device_event_log.h:190: DeviceEventLogInstance
log_instance_;
This is subtle; I missed the comment above the destructor at first, maybe add a
comment above this also (and maybe even in the destructor itself).

https://codereview.chromium.org/947663002/diff/20001/device/hid/hid_connectio...
File device/hid/hid_connection_mac.cc (right):

https://codereview.chromium.org/947663002/diff/20001/device/hid/hid_connectio...
device/hid/hid_connection_mac.cc:64: "0x%04x", result);
nit: We do this a lot here, maybe wrap the StringPrintf in a local helper
function, e.g. HexString(result).

[Reilly Grant (use Gerrit), 2015-02-23 22:40:37]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-02-23 22:40:38]

Ken, please take a look at the HID changes.

https://codereview.chromium.org/947663002/diff/20001/chrome/app/chromium_stri...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/947663002/diff/20001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1356: <message name="IDS_DEVICE_LOG_TYPE_HID"
desc="Checkbox to enable showing events of type HID">
On 2015/02/23 21:45:29, stevenjb wrote:
> Please explain 'HID' in the comment, I don't think it is as well known as,
say,
> USB.

Done.

https://codereview.chromium.org/947663002/diff/20001/components/device_event_...
File components/device_event_log/device_event_log.h (right):

https://codereview.chromium.org/947663002/diff/20001/components/device_event_...
components/device_event_log/device_event_log.h:172: // Implementation class for
DEVICE_PLOG macros. Provides a stream for createing
On 2015/02/23 21:45:29, stevenjb wrote:
> creating

Done.

https://codereview.chromium.org/947663002/diff/20001/components/device_event_...
components/device_event_log/device_event_log.h:190: DeviceEventLogInstance
log_instance_;
On 2015/02/23 21:45:29, stevenjb wrote:
> This is subtle; I missed the comment above the destructor at first, maybe add
a
> comment above this also (and maybe even in the destructor itself).
> 

Done.

https://codereview.chromium.org/947663002/diff/20001/device/hid/hid_connectio...
File device/hid/hid_connection_mac.cc (right):

https://codereview.chromium.org/947663002/diff/20001/device/hid/hid_connectio...
device/hid/hid_connection_mac.cc:64: "0x%04x", result);
On 2015/02/23 21:45:29, stevenjb wrote:
> nit: We do this a lot here, maybe wrap the StringPrintf in a local helper
> function, e.g. HexString(result).

Done.

[stevenjb, 2015-02-23 22:46:46]

chrome/ and components/device_event_log/ lgtm

https://codereview.chromium.org/947663002/diff/40001/components/device_event_...
File components/device_event_log/device_event_log.h (right):

https://codereview.chromium.org/947663002/diff/40001/components/device_event_...
components/device_event_log/device_event_log.h:189: logging::SystemErrorCode
err_;
nit: I was thinking of a comment above log_instance_, something like:

Construction parameters are passed to |log_instace_| which will update the log
when it is destroyed (after |err_| is appended to the stream).

[Ken Rockot(use gerrit already), 2015-02-23 23:10:49]

hid lgtm

[Reilly Grant (use Gerrit), 2015-02-23 23:13:42]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-02-23 23:13:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/947663002/#ps60001 (title:
"A better comment about the embedded log instance.")

[commit-bot: I haz the power, 2015-02-23 23:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947663002/60001

[commit-bot: I haz the power, 2015-02-24 01:28:51]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-02-24 01:29:36]

Patchset 3 (id:??) landed as
https://crrev.com/b9da284b42d4a3b9498d64f1c61452c5f5ae4ff2
Cr-Commit-Position: refs/heads/master@{#317722}