Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 947613003: Add a sanity check to ensure that CDP doesn't hit a cycle (Closed)

Created:
5 years, 10 months ago by Ian Vollick
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a sanity check to ensure that CDP doesn't hit a cycle BUG=455586 Committed: https://crrev.com/1011d5af0e0ee71ac60ee2e74d353a7b9e915fb8 Cr-Commit-Position: refs/heads/master@{#317713}

Patch Set 1 #

Patch Set 2 : s/DCHECK/CHECK/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M cc/layers/draw_properties.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-23 23:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947613003/20001
5 years, 10 months ago (2015-02-24 00:06:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 01:08:26 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:09:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1011d5af0e0ee71ac60ee2e74d353a7b9e915fb8
Cr-Commit-Position: refs/heads/master@{#317713}

Powered by Google App Engine
This is Rietveld 408576698