Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 947583003: DevTools: [network] simplify type column (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: compare resourceType Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/Source/devtools/front_end/network/NetworkDataGridNode.js b/Source/devtools/front_end/network/NetworkDataGridNode.js
index 88c1b341a8a0a20bce8a062484954f1df0101b30..c6957385001a8b88eef1ba39d6ff7965e2927959 100644
--- a/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -108,7 +108,7 @@ WebInspector.NetworkDataGridNode.prototype = {
case "cookies": cell.setTextAndTitle(this._arrayLength(this._request.requestCookies)); break;
case "setCookies": cell.setTextAndTitle(this._arrayLength(this._request.responseCookies)); break;
case "connectionId": cell.setTextAndTitle(this._request.connectionId); break;
- case "type": cell.setTextAndTitle(this._request.mimeType || this._request.requestContentType() || ""); break;
+ case "type": this._renderTypeCell(cell); break;
case "initiator": this._renderInitiatorCell(cell); break;
case "size": this._renderSizeCell(cell); break;
case "time": this._renderTimeCell(cell); break;
@@ -292,6 +292,22 @@ WebInspector.NetworkDataGridNode.prototype = {
/**
* @param {!Element} cell
*/
+ _renderTypeCell: function(cell)
+ {
+ var mimeType = this._request.mimeType || this._request.requestContentType() || "";
+ var resourceType = this._request.resourceType();
+ var simpleType = resourceType.name();
+
+ if (resourceType == WebInspector.resourceTypes.Other
+ || resourceType == WebInspector.resourceTypes.Image)
+ simpleType = mimeType.replace(/^(application|image)\//, "");
+
+ cell.setTextAndTitle(simpleType);
+ },
+
+ /**
+ * @param {!Element} cell
+ */
_renderInitiatorCell: function(cell)
{
this._initiatorCell = cell;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698