Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 947493002: Optimize variation field trial evaluation. (Closed)

Created:
5 years, 10 months ago by Alexei Svitkine (slow)
Modified:
5 years, 10 months ago
Reviewers:
jwd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize variation field trial evaluation. For studies where there is a single group with 100% probability, avoid doing more expensive random entropy computation, since it's not needed to know the final result. BUG=460481 Committed: https://crrev.com/30ac09133a00579c37010f9e0a23434287a736f8 Cr-Commit-Position: refs/heads/master@{#317378}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
M components/variations/processed_study.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/variations/processed_study.cc View 1 4 chunks +24 lines, -9 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 1 chunk +5 lines, -1 line 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Alexei Svitkine (slow)
5 years, 10 months ago (2015-02-20 16:34:32 UTC) #3
jwd
lgtm https://codereview.chromium.org/947493002/diff/20001/components/variations/processed_study.cc File components/variations/processed_study.cc (right): https://codereview.chromium.org/947493002/diff/20001/components/variations/processed_study.cc#newcode60 components/variations/processed_study.cc:60: if (divisor != 0) Clever! If you can ...
5 years, 10 months ago (2015-02-20 18:56:31 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/947493002/diff/20001/components/variations/processed_study.cc File components/variations/processed_study.cc (right): https://codereview.chromium.org/947493002/diff/20001/components/variations/processed_study.cc#newcode60 components/variations/processed_study.cc:60: if (divisor != 0) On 2015/02/20 18:56:31, Jesse Doherty ...
5 years, 10 months ago (2015-02-20 19:03:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947493002/40001
5 years, 10 months ago (2015-02-20 19:03:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947493002/40001
5 years, 10 months ago (2015-02-20 19:42:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-20 19:50:20 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:51:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30ac09133a00579c37010f9e0a23434287a736f8
Cr-Commit-Position: refs/heads/master@{#317378}

Powered by Google App Engine
This is Rietveld 408576698