Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Issue 947483002: Revert of Revert of Make sure MessagePortService is used in a thread safe manner. (Closed)

Created:
5 years, 10 months ago by kaliamoorthi
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #1 id:1 of https://codereview.chromium.org/942583005/) Reason for revert: This does not seem to cause the problem. Original issue's description: > Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #4 id:80001 of https://codereview.chromium.org/937503003/) > > Reason for revert: > This CL is suspected to cause the Win7 test (dbg) failures. > > Original issue's description: > > Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner. > > > > BUG=459115 > > > > Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306 > > Cr-Commit-Position: refs/heads/master@{#317178} > > TBR=creis@chromium.org,sgurun@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=459115 > > Committed: https://crrev.com/60583adc54a6b043dc0b812f10869801eb0da0b4 > Cr-Commit-Position: refs/heads/master@{#317299} TBR=creis@chromium.org,sgurun@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459115 Committed: https://crrev.com/721247d2d4fb18b27c0ccd018c96011b74602a2e Cr-Commit-Position: refs/heads/master@{#317312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M content/browser/message_port_service.cc View 12 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kaliamoorthi
Created Revert of Revert of Make sure MessagePortService is used in a thread safe manner.
5 years, 10 months ago (2015-02-20 14:07:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947483002/1
5 years, 10 months ago (2015-02-20 14:08:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 14:09:18 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:10:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/721247d2d4fb18b27c0ccd018c96011b74602a2e
Cr-Commit-Position: refs/heads/master@{#317312}

Powered by Google App Engine
This is Rietveld 408576698