Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 947463002: Fix bad link in storage doc. (Closed)

Created:
5 years, 10 months ago by Peter Wen
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken link to sync and local storage properties. BUG= Committed: https://crrev.com/13ae7feb3bcd537c4c5e69276d94308c6c25aab0 Cr-Commit-Position: refs/heads/master@{#318261}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use ref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/common/extensions/docs/templates/intros/storage.html View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Wen
PTAL. :)
5 years, 10 months ago (2015-02-20 13:27:14 UTC) #2
Peter Wen
+kalman for documentation OWNERS. Didn't realize pbakaus was only for devtools.
5 years, 10 months ago (2015-02-26 14:46:32 UTC) #4
not at google - send to devlin
lgtm % comment https://codereview.chromium.org/947463002/diff/1/chrome/common/extensions/docs/templates/intros/storage.html File chrome/common/extensions/docs/templates/intros/storage.html (right): https://codereview.chromium.org/947463002/diff/1/chrome/common/extensions/docs/templates/intros/storage.html#newcode95 chrome/common/extensions/docs/templates/intros/storage.html:95: <a href="#property-local">local</a>. Thanks for finding this! ...
5 years, 10 months ago (2015-02-26 16:53:21 UTC) #5
Peter Wen
Done. Thanks! After reading README I realized I should include a preview link too: https://chrome-apps-doc.appspot.com/_patch/947463002/extensions/storage
5 years, 10 months ago (2015-02-26 17:39:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947463002/20001
5 years, 10 months ago (2015-02-26 17:40:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 18:16:55 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:17:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13ae7feb3bcd537c4c5e69276d94308c6c25aab0
Cr-Commit-Position: refs/heads/master@{#318261}

Powered by Google App Engine
This is Rietveld 408576698