Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 947343003: Split out Ash/Aura parts of ChromeNativeAppWindowViews. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out Ash/Aura parts of ChromeNativeAppWindowViews. This will allow us to use ChromeNativeAppWindowViews as a base for ChromeNativeAppWindowViewsMac. BUG=459877 Committed: https://crrev.com/139f2701e564ce9fb0c3c557c35ecb51e77c9085 Cr-Commit-Position: refs/heads/master@{#318164}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : Ready for review. #

Total comments: 24

Patch Set 11 : Address comments #

Total comments: 2

Patch Set 12 : Address comments, retain UpdateShape behavior. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -391 lines) Patch
M chrome/browser/ui/views/apps/chrome_apps_client_views.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +12 lines, -39 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 2 3 4 5 6 7 8 9 10 10 chunks +24 lines, -338 lines 0 comments Download
A chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +355 lines, -0 lines 1 comment Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jackhou1
Bots failed because this is rebased atop the shadow_type change (https://codereview.chromium.org/952103002/). I'll rerun when that ...
5 years, 10 months ago (2015-02-25 04:40:41 UTC) #2
tapted
https://codereview.chromium.org/947343003/diff/180001/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (right): https://codereview.chromium.org/947343003/diff/180001/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc#newcode18 chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:18: #include "ui/aura/window.h" remove? there might be some strays still... ...
5 years, 10 months ago (2015-02-25 05:54:35 UTC) #3
jackhou1
https://codereview.chromium.org/947343003/diff/180001/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (right): https://codereview.chromium.org/947343003/diff/180001/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc#newcode18 chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:18: #include "ui/aura/window.h" On 2015/02/25 05:54:35, tapted wrote: > remove? ...
5 years, 9 months ago (2015-02-25 22:57:52 UTC) #4
tapted
lgtm https://codereview.chromium.org/947343003/diff/180001/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (right): https://codereview.chromium.org/947343003/diff/180001/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc#newcode143 chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:143: init_params.parent = GetImeWindowContainer(); On 2015/02/25 22:57:51, jackhou1 wrote: ...
5 years, 9 months ago (2015-02-25 23:28:09 UTC) #5
jackhou1
https://codereview.chromium.org/947343003/diff/200001/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h File chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h (right): https://codereview.chromium.org/947343003/diff/200001/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h#newcode33 chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h:33: void OnBeforeWidgetInit( On 2015/02/25 23:28:09, tapted wrote: > nit: ...
5 years, 9 months ago (2015-02-25 23:47:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947343003/220001
5 years, 9 months ago (2015-02-25 23:48:26 UTC) #9
commit-bot: I haz the power
Committed patchset #12 (id:220001)
5 years, 9 months ago (2015-02-26 01:03:31 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 01:04:07 UTC) #11
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/139f2701e564ce9fb0c3c557c35ecb51e77c9085
Cr-Commit-Position: refs/heads/master@{#318164}

Powered by Google App Engine
This is Rietveld 408576698