[Ozone-Dri] Gracefully handle DRM devices with no resources

[Ozone-Dri] Gracefully handle DRM devices with no resources

DRM devices such as VGEM do not have resources, so we want to ignore
them rather than crash.

BUG=460982
Committed: https://crrev.com/3b2bde2e135f6125956bc4b526e1a6208111ae53
Cr-Commit-Position: refs/heads/master@{#317687}

[dnicoara, 2015-02-23 21:35:06]

dnicoara@chromium.org changed reviewers:
+ alexst@chromium.org

[dnicoara, 2015-02-23 21:35:07]

PTAL

[alexst (slow to review), 2015-02-23 21:46:32]

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/dri_wr...
File ui/ozone/platform/dri/dri_wrapper.cc (right):

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/dri_wr...
ui/ozone/platform/dri/dri_wrapper.cc:171: return false;
Should reset the plane manager here since it's in an invalid state? I know we
clean up the whole wrapper later, but I prefer we don't leave partially
initialized state since it's unclear from here that failed init means deletion
later.

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/native...
File ui/ozone/platform/dri/native_display_delegate_dri.cc (right):

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/native...
ui/ozone/platform/dri/native_display_delegate_dri.cc:230: LOG(WARNING) << "Could
not initialize DRM device for '" << path.value()
Would this log every time there is a vgem device?

[dnicoara, 2015-02-23 21:49:10]

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/dri_wr...
File ui/ozone/platform/dri/dri_wrapper.cc (right):

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/dri_wr...
ui/ozone/platform/dri/dri_wrapper.cc:171: return false;
On 2015/02/23 21:46:32, alexst wrote:
> Should reset the plane manager here since it's in an invalid state? I know we
> clean up the whole wrapper later, but I prefer we don't leave partially
> initialized state since it's unclear from here that failed init means deletion
> later.

Done.

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/native...
File ui/ozone/platform/dri/native_display_delegate_dri.cc (right):

https://codereview.chromium.org/947293002/diff/1/ui/ozone/platform/dri/native...
ui/ozone/platform/dri/native_display_delegate_dri.cc:230: LOG(WARNING) << "Could
not initialize DRM device for '" << path.value()
On 2015/02/23 21:46:32, alexst wrote:
> Would this log every time there is a vgem device?

Yes.

[dnicoara, 2015-02-23 22:37:38]

As per our offline discussion, added an early check to see if the device can
query for resources and ignore those that can't. Also updated some of the
WARNING logs to VLOG(2)

[alexst (slow to review), 2015-02-23 22:42:49]

lgtm

[dnicoara, 2015-02-23 22:55:58]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-02-23 22:57:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947293002/40001

[commit-bot: I haz the power, 2015-02-23 23:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:29:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dnicoara, 2015-02-23 23:42:45]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947293002/40001

[commit-bot: I haz the power, 2015-02-24 00:26:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-24 00:26:31]

Patchset 3 (id:??) landed as
https://crrev.com/3b2bde2e135f6125956bc4b526e1a6208111ae53
Cr-Commit-Position: refs/heads/master@{#317687}