Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: src/codec/SkCodec.cpp

Issue 947283002: Bmp Image Decoding (Closed) Base URL: https://skia.googlesource.com/skia.git@decode-leon-3
Patch Set: More code sharing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkCodec.h" 8 #include "SkCodec.h"
9 #include "SkData.h" 9 #include "SkData.h"
10 #include "SkCodec_libbmp.h"
10 #include "SkCodec_libpng.h" 11 #include "SkCodec_libpng.h"
11 #include "SkStream.h" 12 #include "SkStream.h"
12 13
14 struct DecoderProc {
15 bool (*IsFormat)(SkStream*);
16 SkCodec* (*NewFromStream)(SkStream*);
17 };
18
19 static const DecoderProc gDecoderProcs[] = {
20 { SkPngCodec::IsPng, SkPngCodec::NewFromStream },
21 { SkBmpCodec::IsBmp, SkBmpCodec::NewFromStream }
22 };
23
13 SkCodec* SkCodec::NewFromStream(SkStream* stream) { 24 SkCodec* SkCodec::NewFromStream(SkStream* stream) {
14 if (!stream) { 25 if (!stream) {
15 return NULL; 26 return NULL;
16 } 27 }
17 SkAutoTDelete<SkStream> streamDeleter(stream); 28 for (DecoderProc proc : gDecoderProcs) {
18 const bool isPng = SkPngCodec::IsPng(stream); 29 const bool correctFormat = proc.IsFormat(stream);
19 // TODO: Avoid rewinding. 30 if (!stream->rewind()) {
20 if (!stream->rewind()) { 31 return NULL;
21 return NULL; 32 }
33 if (correctFormat) {
34 return proc.NewFromStream(stream);
35 }
22 } 36 }
23 if (isPng) {
24 streamDeleter.detach();
25 return SkPngCodec::NewFromStream(stream);
26 }
27 // TODO: Check other image types.
28 return NULL; 37 return NULL;
29 } 38 }
30 39
31 SkCodec* SkCodec::NewFromData(SkData* data) { 40 SkCodec* SkCodec::NewFromData(SkData* data) {
32 if (!data) { 41 if (!data) {
33 return NULL; 42 return NULL;
34 } 43 }
35 return NewFromStream(SkNEW_ARGS(SkMemoryStream, (data))); 44 return NewFromStream(SkNEW_ARGS(SkMemoryStream, (data)));
36 } 45 }
37 46
38 SkCodec::SkCodec(const SkImageInfo& info, SkStream* stream) 47 SkCodec::SkCodec(const SkImageInfo& info, SkStream* stream)
39 : fInfo(info) 48 : fInfo(info)
40 , fStream(stream) 49 , fStream(stream)
41 , fNeedsRewind(false) 50 , fNeedsRewind(false)
42 {} 51 {}
43 52
44 bool SkCodec::rewindIfNeeded() { 53 bool SkCodec::rewindIfNeeded() {
45 // Store the value of fNeedsRewind so we can update it. Next read will 54 // Store the value of fNeedsRewind so we can update it. Next read will
46 // require a rewind. 55 // require a rewind.
47 const bool neededRewind = fNeedsRewind; 56 const bool neededRewind = fNeedsRewind;
48 fNeedsRewind = true; 57 fNeedsRewind = true;
49 return !neededRewind || fStream->rewind(); 58 return !neededRewind || fStream->rewind();
50 } 59 }
OLDNEW
« no previous file with comments | « include/codec/SkCodec.h ('k') | src/codec/SkCodecPriv.h » ('j') | src/codec/SkCodec_libbmp.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698