Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 947253002: Hide Autofill/Wallet preferences on Android. (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide Autofill/Wallet preferences on Android. Simply hide the Autofill/Wallet preferences. The correct fix will involve checking the state of the sync experiment, but for M42 it's enough to just disable this preference page. Will require merge to m42. BUG=460900 R=aurimas@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/652772cfbf2ccf99d63b13f606cbaed035efdf88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
5 years, 10 months ago (2015-02-23 18:26:40 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 10 months ago (2015-02-23 18:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947253002/1
5 years, 10 months ago (2015-02-23 18:38:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61789)
5 years, 10 months ago (2015-02-23 18:41:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947253002/1
5 years, 10 months ago (2015-02-23 22:59:13 UTC) #9
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-23 23:12:16 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/652772cfbf2ccf99d63b13f606cbaed035efdf88 Cr-Commit-Position: refs/heads/master@{#317699}
5 years, 10 months ago (2015-02-24 00:51:28 UTC) #13
Evan Stade
5 years, 10 months ago (2015-02-24 00:51:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
652772cfbf2ccf99d63b13f606cbaed035efdf88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698