Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 947233003: Chromecast buildfix: restores AddKeySystemWithCodecs, fixes namespace. (Closed)

Created:
5 years, 10 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast buildfix: restores AddKeySystemWithCodecs, fixes namespace. This is a partial revert of https://codereview.chromium.org/923283002 for chromecast/, since we reference AddKeySystemWithCodecs from internal code. The functional changes are kept but the API changes are reverted. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/e74cff743e37d9fcbe5c5689d7480f21ef2ca936 Cr-Commit-Position: refs/heads/master@{#317641}

Patch Set 1 #

Patch Set 2 : re-add AddKeySystemWithCodecs #

Total comments: 2

Patch Set 3 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M chromecast/renderer/key_systems_cast.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chromecast/renderer/key_systems_cast.cc View 1 2 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
gunsch
5 years, 10 months ago (2015-02-23 19:02:30 UTC) #1
lcwu1
lgtm
5 years, 10 months ago (2015-02-23 19:16:28 UTC) #2
lcwu1
https://codereview.chromium.org/947233003/diff/20001/chromecast/renderer/key_systems_cast.cc File chromecast/renderer/key_systems_cast.cc (right): https://codereview.chromium.org/947233003/diff/20001/chromecast/renderer/key_systems_cast.cc#newcode20 chromecast/renderer/key_systems_cast.cc:20: void AddKeySystemWithCodecs( Also we might want to add a ...
5 years, 10 months ago (2015-02-23 19:18:29 UTC) #3
gunsch
https://codereview.chromium.org/947233003/diff/20001/chromecast/renderer/key_systems_cast.cc File chromecast/renderer/key_systems_cast.cc (right): https://codereview.chromium.org/947233003/diff/20001/chromecast/renderer/key_systems_cast.cc#newcode20 chromecast/renderer/key_systems_cast.cc:20: void AddKeySystemWithCodecs( On 2015/02/23 19:18:29, lcwu1 wrote: > Also ...
5 years, 10 months ago (2015-02-23 19:30:54 UTC) #4
lcwu1
On 2015/02/23 19:30:54, gunsch wrote: > https://codereview.chromium.org/947233003/diff/20001/chromecast/renderer/key_systems_cast.cc > File chromecast/renderer/key_systems_cast.cc (right): > > https://codereview.chromium.org/947233003/diff/20001/chromecast/renderer/key_systems_cast.cc#newcode20 > ...
5 years, 10 months ago (2015-02-23 19:36:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947233003/40001
5 years, 10 months ago (2015-02-23 20:12:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-23 20:32:29 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:32:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e74cff743e37d9fcbe5c5689d7480f21ef2ca936
Cr-Commit-Position: refs/heads/master@{#317641}

Powered by Google App Engine
This is Rietveld 408576698