Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 94723002: Swap cp and pp registers on Arm such for work on OOL Constant Pool. (Closed)

Created:
7 years ago by rmcilroy
Modified:
7 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Swap cp and pp registers on Arm such for work on OOL Constant Pool. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18127

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix upload #

Patch Set 4 : Rebase and fix one missing instance of pp/cp swap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M src/arm/assembler-arm.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M src/arm/frames-arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmcilroy
7 years ago (2013-11-28 11:45:44 UTC) #1
Benedikt Meurer
Upload seems to be broken.
7 years ago (2013-11-28 12:08:46 UTC) #2
rmcilroy
On 2013/11/28 12:08:46, Benedikt Meurer wrote: > Upload seems to be broken. Argh, what is ...
7 years ago (2013-11-28 12:14:51 UTC) #3
Benedikt Meurer
LGTM
7 years ago (2013-11-28 12:16:44 UTC) #4
rmcilroy
7 years ago (2013-11-28 14:13:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r18127 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698