Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 947203002: [Cronet] Move PostTask out of DCHECK. (Closed)

Created:
5 years, 10 months ago by xunjieli
Modified:
5 years, 10 months ago
Reviewers:
mef, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Move PostTask out of DCHECK. DCHECK is removed in release builds, so we should move PostTask out of DCHECK. Committed: https://crrev.com/e42d8cb058ab290680880bfb40825269ed615181 Cr-Commit-Position: refs/heads/master@{#317601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/android/cronet_upload_data_stream_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xunjieli
5 years, 10 months ago (2015-02-23 16:32:11 UTC) #2
mef
lgtm
5 years, 10 months ago (2015-02-23 16:45:02 UTC) #3
xunjieli
On 2015/02/23 16:45:02, mef wrote: > lgtm Thanks! Seems Matt's OOO, so I am going ...
5 years, 10 months ago (2015-02-23 16:50:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947203002/1
5 years, 10 months ago (2015-02-23 16:51:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 17:11:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:12:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e42d8cb058ab290680880bfb40825269ed615181
Cr-Commit-Position: refs/heads/master@{#317601}

Powered by Google App Engine
This is Rietveld 408576698