Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 947173002: Remove duplicate includes from chromeos/ (Closed)

Created:
5 years, 10 months ago by pneubeck (no reviews)
Modified:
5 years, 10 months ago
Reviewers:
satorux1
CC:
chromium-reviews, hashimoto+watch_chromium.org, derat+watch_chromium.org, tfarina, dkrahn+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate includes from chromeos/ This removes all includes from $X.cc files where the $X.h has the same include to conform to the style guide: "[...] However, any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes)." BUG=460988 Committed: https://crrev.com/54d39217d6ced9a3b8f025ba6bf4ab2e8588dcbc Cr-Commit-Position: refs/heads/master@{#318002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -111 lines) Patch
M chromeos/attestation/mock_attestation_flow.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/cryptohome/async_method_caller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_adapter_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_agent_manager_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_agent_service_provider.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/bluetooth_device_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_input_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_media_endpoint_service_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_profile_manager_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_profile_service_provider.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_adapter_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_agent_manager_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_agent_service_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_input_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_manager_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_service_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_nfc_adapter_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_nfc_device_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_nfc_tag_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_power_manager_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_shill_profile_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/introspectable_client.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/leadership_daemon_manager_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/lorgnette_manager_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/permission_broker_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/dbus/services/cros_dbus_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/services/display_power_service_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/services/service_provider_test_helper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/shill_client_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/system_clock_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/update_engine_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/geolocation/simple_geolocation_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/geolocation/simple_geolocation_request.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/login/auth/auth_attempt_state.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/login/auth/extended_authenticator_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login/auth/mock_url_fetchers.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/login/auth/online_attempt.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/login/auth/online_attempt_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login/auth/test_attempt_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/auto_connect_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/client_cert_resolver.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/network/client_cert_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/network/device_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/network_configuration_handler.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/network/network_device_handler_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/network_sms_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/network/network_ui_data.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_validator.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/timezone/timezone_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/timezone/timezone_request.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/timezone/timezone_resolver.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pneubeck (no reviews)
Hi Satoru, what do you think of this removal? Please see the bug for a ...
5 years, 10 months ago (2015-02-24 13:23:06 UTC) #2
satorux1
On 2015/02/24 13:23:06, pneubeck wrote: > Hi Satoru, > what do you think of this ...
5 years, 10 months ago (2015-02-25 01:30:52 UTC) #3
satorux1
LGTM. I'm not sure if we want to do this to all the chrome code ...
5 years, 10 months ago (2015-02-25 01:36:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947173002/1
5 years, 10 months ago (2015-02-25 08:53:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 09:40:13 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 09:41:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54d39217d6ced9a3b8f025ba6bf4ab2e8588dcbc
Cr-Commit-Position: refs/heads/master@{#318002}

Powered by Google App Engine
This is Rietveld 408576698