[turbofan] encode instruction operand as uint64_t

[turbofan] encode instruction operand as uint64_t

R=bmeurer@chromium.org

BUG=

Committed: https://crrev.com/92ccbefe1186ff11420444208a0e22fa1154ab6c
Cr-Commit-Position: refs/heads/master@{#26809}

[dcarney, 2015-02-23 14:37:03]

Patchset #1 (id:1) has been deleted

[dcarney, 2015-02-23 14:45:55]

dcarney@chromium.org changed reviewers:
+ bmeurer@chromium.org

[dcarney, 2015-02-23 14:46:03]

ptal

[Benedikt Meurer, 2015-02-23 18:33:49]

https://codereview.chromium.org/947153002/diff/20001/src/utils.h
File src/utils.h (right):

https://codereview.chromium.org/947153002/diff/20001/src/utils.h#newcode211
src/utils.h:211: static const T kMax = static_cast<T>((kOne << size) - 1);
The looks a lot like undefined behavior for signed T's to me. Can we avoid that
somehow?

[dcarney, 2015-02-23 18:56:08]

https://codereview.chromium.org/947153002/diff/20001/src/utils.h
File src/utils.h (right):

https://codereview.chromium.org/947153002/diff/20001/src/utils.h#newcode211
src/utils.h:211: static const T kMax = static_cast<T>((kOne << size) - 1);
On 2015/02/23 18:33:49, Benedikt Meurer wrote:
> The looks a lot like undefined behavior for signed T's to me. Can we avoid
that
> somehow?

this doesn't change the current behaviour, just makes it correct for BitField64.
 kMax probably shouldn't be exposed to the world, just used for the is_valid
calculation, where it's anyway converted back to unsigned

[Benedikt Meurer, 2015-02-24 05:42:23]

lgtm

[dcarney, 2015-02-24 08:05:27]

The CQ bit was checked by dcarney@chromium.org

[commit-bot: I haz the power, 2015-02-24 08:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947153002/20001

[commit-bot: I haz the power, 2015-02-24 08:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 08:06:43]

CQ experienced an internal error when committing your CL and the maintainers
were notified. Sorry for the inconvenience.

[commit-bot: I haz the power, 2015-02-24 08:06:49]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-02-24 08:07:05]

Patchset 1 (id:??) landed as
https://crrev.com/92ccbefe1186ff11420444208a0e22fa1154ab6c
Cr-Commit-Position: refs/heads/master@{#26809}