[bindings] Split toUInt32 into faster inline and non-inline slower path.

Source/bindings/core/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 333 matching lines @@
 
     return numberObject->Int32Value();
 }
 
 int32_t toInt32(v8::Handle<v8::Value> value)
 {
     NonThrowableExceptionState exceptionState;
     return toInt32(value, NormalConversion, exceptionState);
 }
 
-uint32_t toUInt32(v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
+uint32_t toUInt32Slow(v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
 {
-    // Fast case. The value is already a 32-bit unsigned integer.
-    if (value->IsUint32())
-        return value->Uint32Value();
-
-    // Fast case. The value is a 32-bit signed integer - possibly positive?
+    ASSERT(!value->IsUint32());
     if (value->IsInt32()) {
+        ASSERT(configuration != NormalConversion);
         int32_t result = value->Int32Value();
         if (result >= 0)
             return result;
         if (configuration == EnforceRange) {
             exceptionState.throwTypeError("Value is outside the 'unsigned long' value range.");
             return 0;
+        } else {

[Jens Widell, 2015/02/24 07:43:09]

No need for an else branch here since the if-statement's true branch returns.

+            ASSERT(configuration == Clamp);
+            return clampTo<uint32_t>(result);
         }
-        if (configuration == Clamp)
-            return clampTo<uint32_t>(result);
-        return result;
     }
 
-    v8::Local<v8::Number> numberObject;
-    if (value->IsNumber()) {
-        numberObject = value.As<v8::Number>();
-    } else {
-        v8::Isolate* isolate = v8::Isolate::GetCurrent();
-        // Can the value be converted to a number?
-        v8::TryCatch block(isolate);
-        numberObject = value->ToNumber(isolate);
-        if (block.HasCaught()) {
-            exceptionState.rethrowV8Exception(block.Exception());
-            return 0;
-        }
+    v8::Isolate* isolate = v8::Isolate::GetCurrent();
+    // Can the value be converted to a number?
+    v8::TryCatch block(isolate);
+    v8::Local<v8::Number> numberObject = value->ToNumber(isolate);
+    if (block.HasCaught()) {
+        exceptionState.rethrowV8Exception(block.Exception());
+        return 0;
     }
     ASSERT(!numberObject.IsEmpty());
 
     if (configuration == EnforceRange)
         return enforceRange(numberObject->Value(), 0, kMaxUInt32, "unsigned long", exceptionState);
 
     double numberValue = numberObject->Value();
 
     if (std::isnan(numberValue))
         return 0;
@@ skipping 690 matching lines @@
         attributes->append(value);
 }
 
 AttributesWithSideEffectOnGet::AttributeSet* AttributesWithSideEffectOnGet::attributesWithSideEffectOnGet()
 {
     DEFINE_STATIC_LOCAL(AttributeSet, attributes, ());
     return &attributes;
 }
 
 } // namespace blink