Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 947113002: Revert of Add AwAssets into android_webview/native/public (Closed)

Created:
5 years, 10 months ago by binjin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add AwAssets into android_webview/native/public (patchset #4 id:70009 of https://codereview.chromium.org/937863003/) Reason for revert: Suspected to cause 'checkdeps' failures on Linux bot: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/20990/steps/checkdeps/logs/stdio ERROR in /mnt/data/b/build/slave/Linux_Tests/build/src/android_webview/browser/aw_dev_tools_manager_delegate.cc Illegal include: "android_webview/native/aw_contents.h" Because of "-android_webview" from android_webview/browser's include_rules. Original issue's description: > Add AwAssets into android_webview/native/public > > This is done so that android_webview/browser doesn't need to depend on > android_webview/native > > BUG=459779 > > Committed: https://crrev.com/a08360b39730751c5f85797bdff5b748d907c11a > Cr-Commit-Position: refs/heads/master@{#317475} TBR=boliu@chromium.org,sgurun@chromium.org,hush@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459779 Committed: https://crrev.com/34cd1a9f17f7b4509753b0184e7ac3463ab43d13 Cr-Commit-Position: refs/heads/master@{#317567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -98 lines) Patch
M android_webview/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/android_webview_jni_registrar.cc View 2 chunks +1 line, -1 line 0 comments Download
A android_webview/native/aw_assets.h View 1 chunk +36 lines, -0 lines 0 comments Download
A android_webview/native/aw_assets.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M android_webview/native/aw_media_url_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
D android_webview/native/public/aw_assets.h View 1 chunk +0 lines, -36 lines 0 comments Download
D android_webview/native/public/aw_assets.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M android_webview/native/webview_native.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binjin
Created Revert of Add AwAssets into android_webview/native/public
5 years, 10 months ago (2015-02-23 11:19:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947113002/1
5 years, 10 months ago (2015-02-23 11:20:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 11:21:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/34cd1a9f17f7b4509753b0184e7ac3463ab43d13 Cr-Commit-Position: refs/heads/master@{#317567}
5 years, 10 months ago (2015-02-23 11:21:56 UTC) #4
hush (inactive)
5 years, 9 months ago (2015-02-26 18:57:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/957423002/ by hush@chromium.org.

The reason for reverting is: https://codereview.chromium.org/950973003/ is just
landed to fix the deps problem..

Powered by Google App Engine
This is Rietveld 408576698