base/trace_event/process_memory_totals.cc - Issue 947103003: [tracing] Improve the memory maps dumper generation format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_totals.cc

Issue 947103003: [tracing] Improve the memory maps dumper generation format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Petr's comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/process_memory_totals.cc

diff --git a/base/trace_event/process_memory_totals.cc b/base/trace_event/process_memory_totals.cc

index 41ad788ea4bff48097461f16670fee084087d923..9b0c3776eea2aefae9f8bc050b68a04e5ba6b46b 100644

--- a/base/trace_event/process_memory_totals.cc

+++ b/base/trace_event/process_memory_totals.cc

@@ -4,13 +4,16 @@

#include "base/trace_event/process_memory_totals.h"

+#include "base/format_macros.h"

+#include "base/strings/stringprintf.h"

#include "base/trace_event/trace_event_argument.h"

namespace base {

namespace trace_event {

void ProcessMemoryTotals::AsValueInto(TracedValue* value) const {

- value->SetDouble("resident_set_bytes", resident_set_bytes_);

+ value->SetString("resident_set_bytes",

+ StringPrintf("%" PRIx64, resident_set_bytes_));

}

} // namespace trace_event

« no previous file with comments | « base/trace_event/process_memory_totals.h ('k') | base/trace_event/process_memory_totals_dump_provider_unittest.cc » ('j') | no next file with comments »