[Files.app] Refine tabindexes

[Files.app] Refine tabindexes

- Refine tabindex following visual and logical order
- Make the breadcrumbs focusable  (except the last one)

BUG=459693
TEST=manually

Committed: https://crrev.com/a5b3c8add9a5d250b20832c3c919feab422a058f
Cr-Commit-Position: refs/heads/master@{#317749}

[yoshiki, 2015-02-23 09:58:01]

yoshiki@chromium.org changed reviewers:
+ fukino@chromium.org

[yoshiki, 2015-02-23 09:59:08]

@fukino-san, could you take a look? Please see go/filesapp-tabindex as well.

[fukino, 2015-02-23 10:20:34]

lgtm with a nit. Thanks!

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/banners.js (right):

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/banners.js:192: more.tabIndex =
'19';  // See: go/filesapp-tabindex.
Is it OK to use go link in open source code? Though it's already exist before
this CL...

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/location_line.js (right):

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/location_line.js:235: * @param
{!PathComponent} pathComponent Path Component object of the element.
nit: !LocationLine.PathComponent

[yoshiki, 2015-02-23 10:23:35]

New patchsets have been uploaded after l-g-t-m from fukino@chromium.org

[yoshiki, 2015-02-23 10:24:34]

Thanks!

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/banners.js (right):

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/banners.js:192: more.tabIndex =
'19';  // See: go/filesapp-tabindex.
On 2015/02/23 10:20:34, fukino wrote:
> Is it OK to use go link in open source code? Though it's already exist before
> this CL...

I think it's ok and it prevents us from unexpected change.

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/location_line.js (right):

https://codereview.chromium.org/947083002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/location_line.js:235: * @param
{!PathComponent} pathComponent Path Component object of the element.
On 2015/02/23 10:20:34, fukino wrote:
> nit: !LocationLine.PathComponent

Done.

[yoshiki, 2015-02-23 10:24:38]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-02-23 10:25:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947083002/20001

[commit-bot: I haz the power, 2015-02-23 10:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 10:28:11]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[yoshiki, 2015-02-23 17:17:08]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-02-23 17:18:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947083002/20001

[commit-bot: I haz the power, 2015-02-23 17:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 17:20:55]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[yoshiki, 2015-02-24 01:05:38]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-02-24 01:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947083002/20001

[commit-bot: I haz the power, 2015-02-24 01:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 01:32:48]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2015-02-24 01:56:29]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-02-24 01:56:34]

The CQ bit was unchecked by yoshiki@chromium.org

[yoshiki, 2015-02-24 02:39:30]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-02-24 02:39:31]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/947083002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-02-24 02:40:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947083002/40001

[commit-bot: I haz the power, 2015-02-24 03:05:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-24 03:05:48]

Patchset 3 (id:??) landed as
https://crrev.com/a5b3c8add9a5d250b20832c3c919feab422a058f
Cr-Commit-Position: refs/heads/master@{#317749}