Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 94703002: Add fast make and test all target. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
Reviewers:
Yang, danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add fast make and test all target. The new target called "quickcheck" builds and tests with several configurations using recent test runner speed improvements. Runtime from scratch (after make clean): < 8 min Runtime tests only: < 3 min TEST=make quickcheck R=jkummerow@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18120

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Addressed review comments. #

Patch Set 3 : Addressed more comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M Makefile View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 4 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-11-28 11:51:28 UTC) #1
Yang
On 2013/11/28 11:51:28, machenbach wrote: > PTAL LGTM
7 years ago (2013-11-28 12:16:20 UTC) #2
Jakob Kummerow
LGTM with a nit and a high-level comment: "fast" is way too generic as a ...
7 years ago (2013-11-28 12:44:29 UTC) #3
Michael Achenbach
7 years ago (2013-11-28 13:18:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r18120 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698