Source/core/css/invalidation/DescendantInvalidationSet.h - Issue 946993002: Avoid style invalidation for empty sets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/invalidation/DescendantInvalidationSet.h

Issue 946993002: Avoid style invalidation for empty sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added dummy selectors to tests to force descendant invalidation Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/invalidation/DescendantInvalidationSet.h

diff --git a/Source/core/css/invalidation/DescendantInvalidationSet.h b/Source/core/css/invalidation/DescendantInvalidationSet.h

index b233e2011f7d0e4f981f0c58818bf39b75852135..28533ecff5d5a2a59a20dccb4e7052af79e4640b 100644

--- a/Source/core/css/invalidation/DescendantInvalidationSet.h

+++ b/Source/core/css/invalidation/DescendantInvalidationSet.h

@@ -76,7 +76,7 @@ public:

void setCustomPseudoInvalid() { m_customPseudoInvalid = true; }

bool customPseudoInvalid() const { return m_customPseudoInvalid; }

- bool isEmpty() const { return !m_classes && !m_ids && !m_tagNames && !m_attributes; }

+ bool isEmpty() const { return !m_classes && !m_ids && !m_tagNames && !m_attributes && !m_customPseudoInvalid; }

void trace(Visitor*);