Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/bindings/scripts/v8_union.py

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: minor cleanup Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/templates/conversions.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_union.py
diff --git a/Source/bindings/scripts/v8_union.py b/Source/bindings/scripts/v8_union.py
index 4ed138fac624837e7d9b30a32819fd6e9c5c1986..ef7c1ca6c84e164c8c130393a88cd62568af62d1 100644
--- a/Source/bindings/scripts/v8_union.py
+++ b/Source/bindings/scripts/v8_union.py
@@ -150,5 +150,6 @@ def member_context(member, interfaces_info):
'type_name': member.name,
'v8_value_to_local_cpp_value': member.v8_value_to_local_cpp_value(
{}, 'v8Value', 'cppValue', isolate='isolate',
- needs_exception_state_for_string=True, restricted_float=True),
+ bailout_return_value='false', use_exception_state=True,
+ restricted_float=True),
}
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/templates/conversions.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698