Source/bindings/tests/results/modules/UnionTypesModules.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/modules/UnionTypesModules.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestTypedefs.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/modules/UnionTypesModules.cpp

diff --git a/Source/bindings/tests/results/modules/UnionTypesModules.cpp b/Source/bindings/tests/results/modules/UnionTypesModules.cpp

index 6438e18dd44c7c5b7e81fde3f33ddab95f11f56b..75ba666b57eb93700a0133cc800ea1bc90c16824 100644

--- a/Source/bindings/tests/results/modules/UnionTypesModules.cpp

+++ b/Source/bindings/tests/results/modules/UnionTypesModules.cpp

@@ -66,7 +66,9 @@ void V8BooleanOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Valu

}

{

- TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);

+ V8StringResource<> cppValue = v8Value;

+ if (!cppValue.prepare(exceptionState))

+ return;

impl.setString(cppValue);

return;

}