Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
diff --git a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
index ea4cbb766dd8e0fcdf51e17dfd2e28a6a45095dc..32f934372d0b3788986d6e690ab021ba6dc75944 100644
--- a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
+++ b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
@@ -45,7 +45,9 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
TestSpecialOperations* impl = V8TestSpecialOperations::toImpl(info.Holder());
V8StringResource<> name;
{
- TOSTRING_VOID_INTERNAL(name, info[0]);
+ name = info[0];
+ if (!name.prepare())
+ return;
}
NodeOrNodeList result;
impl->getItem(name, result);
@@ -86,7 +88,9 @@ static void namedPropertySetter(v8::Local<v8::Name> name, v8::Local<v8::Value> v
return;
auto nameString = name.As<v8::String>();
TestSpecialOperations* impl = V8TestSpecialOperations::toImpl(info.Holder());
- TOSTRING_VOID(V8StringResource<>, propertyName, nameString);
+ V8StringResource<> propertyName(nameString);
+ if (!propertyName.prepare())
+ return;
Node* propertyValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!propertyValue && !isUndefinedOrNull(v8Value)) {
exceptionState.throwTypeError("The provided value is not of type 'Node'.");
« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/bindings/tests/results/core/V8TestTypedefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698