Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
index de4760007f7d9cbca644d989cba5df38039814d3..4fe629a2ca9073a90198001af966688bc6edc02e 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
@@ -56,13 +56,17 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
V8StringResource<> type;
TestInterfaceEventInit testInterfaceEventInit;
{
- TOSTRING_VOID_INTERNAL(type, info[0]);
+ type = info[0];
+ if (!type.prepare())
+ return;
if (!isUndefinedOrNull(info[1]) && !info[1]->IsObject()) {
exceptionState.throwTypeError("parameter 2 ('testInterfaceEventInit') is not an object.");
exceptionState.throwIfNeeded();
return;
}
- TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL(V8TestInterfaceEventInit::toImpl(info.GetIsolate(), info[1], testInterfaceEventInit, exceptionState), exceptionState);
+ V8TestInterfaceEventInit::toImpl(info.GetIsolate(), info[1], testInterfaceEventInit, exceptionState);
+ if (exceptionState.throwIfNeeded())
+ return;
}
RefPtrWillBeRawPtr<TestInterfaceEventInitConstructor> impl = TestInterfaceEventInitConstructor::create(type, testInterfaceEventInit);
v8::Local<v8::Object> wrapper = info.Holder();

Powered by Google App Engine
This is Rietveld 408576698