Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

index fa11ad9b8d61d6c799ab15d13af2df409f2bf081..0ae1685fe78ba5f122c241fe488c227d612ce129 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

@@ -48,7 +48,9 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor4", info.Holder(), info.GetIsolate());

V8StringResource<> usvStringArg;

{

- TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(usvStringArg, toUSVString(info[0], exceptionState), exceptionState);

+ usvStringArg = toUSVString(info[0], exceptionState);

+ if (exceptionState.throwIfNeeded())

+ return;

}

RefPtr<TestInterfaceConstructor4> impl = TestInterfaceConstructor4::create(usvStringArg);

v8::Local<v8::Object> wrapper = info.Holder();