Source/bindings/tests/results/core/V8SVGTestInterface.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8SVGTestInterface.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/UnionTypesCore.cpp ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8SVGTestInterface.cpp

diff --git a/Source/bindings/tests/results/core/V8SVGTestInterface.cpp b/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

index ecb9c67195a619aad408b115e5b8a40c9e325ac6..22c1ae8a9dc21f2fe84d9a1fef8076af7e23594b 100644

--- a/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

+++ b/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

@@ -49,7 +49,9 @@ static void typeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Property

{

v8::Local<v8::Object> holder = info.Holder();

SVGTestInterface* impl = V8SVGTestInterface::toImpl(holder);

- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);

+ V8StringResource<> cppValue = v8Value;

+ if (!cppValue.prepare())

+ return;

CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;

impl->setAttribute(SVGNames::typeAttr, cppValue);

}

« no previous file with comments | « Source/bindings/tests/results/core/UnionTypesCore.cpp ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »