Source/bindings/templates/templates.gni - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/templates.gni

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/templates.gni

diff --git a/Source/bindings/templates/templates.gni b/Source/bindings/templates/templates.gni

index 69dcdc752fdd73c0084d9bdc51b78f0dd6de7318..d3d1e23eacd029275f8eb4e8308b81aa70bbb3cf 100644

--- a/Source/bindings/templates/templates.gni

+++ b/Source/bindings/templates/templates.gni

@@ -10,6 +10,7 @@ code_generator_template_files =

"callback_interface.cpp",

"callback_interface.h",

"constants.cpp",

+ "conversions.cpp",

"dictionary_impl.cpp",

"dictionary_impl.h",

"dictionary_v8.cpp",

« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/templates/templates.gypi » ('j') | no next file with comments »