Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_types.py ('K') | « Source/bindings/tests/results/core/V8TestInterface3.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp b/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

index 4edd95c60e9b543a975e71c1eff491ce3d1223fe..65a54fba1d9eb14b5dbffeb05f428c265d7fbc14 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

@@ -63,7 +63,7 @@ static void doNotCheckSecurityLongAttributeAttributeSetter(v8::Local<v8::Value>

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "doNotCheckSecurityLongAttribute", "TestInterfaceCheckSecurity", holder, info.GetIsolate());

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);

- TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);

+ TONATIVE_DECLARE(int, cppValue, convertAndThrow(cppValue = toInt32(v8Value, exceptionState), exceptionState), return);

impl->setDoNotCheckSecurityLongAttribute(cppValue);

}

@@ -107,7 +107,7 @@ static void doNotCheckSecurityOnSetterLongAttributeAttributeSetter(v8::Local<v8:

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "doNotCheckSecurityOnSetterLongAttribute", "TestInterfaceCheckSecurity", holder, info.GetIsolate());

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);

- TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);

+ TONATIVE_DECLARE(int, cppValue, convertAndThrow(cppValue = toInt32(v8Value, exceptionState), exceptionState), return);

impl->setDoNotCheckSecurityOnSetterLongAttribute(cppValue);

}