Source/bindings/templates/attributes.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index f7bc807acd6fcd53e79afed39c967926936fb1f9..cc670fa0994c5b2cd5cc3158da2d2ca121084ffc 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -217,9 +217,6 @@ v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info

{% if attribute.has_setter_exception_state %}

ExceptionState exceptionState(ExceptionState::SetterContext, "{{attribute.name}}", "{{interface_name}}", holder, info.GetIsolate());

{% endif %}

- {% if attribute.use_output_parameter_for_result %}

- {{attribute.cpp_type}} cppValue;

- {% endif %}

{# impl #}

{% if attribute.put_forwards %}

{{cpp_class}}* proxyImpl = {{v8_class}}::toImpl(holder);

« Source/bindings/scripts/v8_types.py ('K') | « Source/bindings/scripts/v8_union.py ('k') | Source/bindings/templates/dictionary_v8.h » ('j') | no next file with comments »