Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: Source/bindings/core/v8/ExceptionState.h

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.h » ('j') | Source/bindings/core/v8/V8Binding.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ExceptionState.h
diff --git a/Source/bindings/core/v8/ExceptionState.h b/Source/bindings/core/v8/ExceptionState.h
index 3acd126e8b3af60582f566143500b7c7a8bcb119..9683f5ded5f3fbad29e60aef5fd9df5315ba4ff5 100644
--- a/Source/bindings/core/v8/ExceptionState.h
+++ b/Source/bindings/core/v8/ExceptionState.h
@@ -96,6 +96,8 @@ public:
return true;
}
+ void throwException();
yhirano 2015/02/24 03:51:24 Can you tell me why you want this function in addi
Jens Widell 2015/02/24 07:31:43 I use it in a situation where I know an exception
Jens Widell 2015/02/24 15:34:56 I've reverted this change, as it wasn't really req
+
// This method clears out the exception which |this| has.
ScriptPromise reject(ScriptState*);
@@ -121,7 +123,6 @@ protected:
private:
void setException(v8::Handle<v8::Value>);
- void throwException();
String addExceptionContext(const String&) const;
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.h » ('j') | Source/bindings/core/v8/V8Binding.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698