IDL: Drop value conversion (V8 -> C++) macros from generated code

Source/bindings/templates/conversions.cpp

Index: Source/bindings/templates/conversions.cpp
diff --git a/Source/bindings/templates/conversions.cpp b/Source/bindings/templates/conversions.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..0d3c1c68ed87e404ff79b3caa32673beb76a8798
--- /dev/null
+++ b/Source/bindings/templates/conversions.cpp
@@ -0,0 +1,33 @@
+{% macro v8_value_to_local_cpp_value(thing) %}
+{# This indirection is just to avoid spurious white-space lines. #}
+{{generate_v8_value_to_local_cpp_value(thing) | trim}}
+{%- endmacro %}
+
+
+{% macro generate_v8_value_to_local_cpp_value(thing) %}
+{% set item = thing.v8_value_to_local_cpp_value or thing %}

[bashi, 2015/02/25 04:44:35]

Just a comment:
I guess you do this to avoid writing |thing.v8_value_to_local_cpp_value| in call
sites, but it may make readers difficult to understand what argument type this
macro takes.

+{% if item.error_message %}
+/* {{item.error_message}} */
+{% else %}
+{% if item.declare_variable %}
+{% if item.assign_expression %}
+{{item.cpp_type}} {{item.cpp_name}} = {{item.assign_expression}};
+{% else %}
+{{item.cpp_type}} {{item.cpp_name}};
+{% endif %}
+{% else %}{# item.declare_variable #}
+{% if item.assign_expression %}
+{{item.cpp_name}} = {{item.assign_expression}};
+{% endif %}
+{% endif %}{# item.declare_variable #}
+{% if item.set_expression %}
+{{item.set_expression}};
+{% endif %}
+{% if item.check_expression %}
+if ({{item.check_expression}})
+    return{% if item.return_expression %} {{item.return_expression}}{% endif %};
+{% endif %}{# item.check_expression #}
+{% endif %}{# item.error_message #}
+{% endmacro %}
+
+

[bashi, 2015/02/25 04:44:35]

nit: remove the second empty line?

[Jens Widell, 2015/02/25 07:49:43]

Done.