IDL: Drop value conversion (V8 -> C++) macros from generated code

Source/bindings/tests/results/core/UnionTypesCore.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
 
 #include "config.h"
 #include "bindings/core/v8/UnionTypesCore.h"
 
 #include "bindings/core/v8/Dictionary.h"
@@ skipping 78 matching lines @@
     m_type = SpecificTypeDictionary;
 }
 
 ArrayBufferOrArrayBufferViewOrDictionary ArrayBufferOrArrayBufferViewOrDictionary::fromDictionary(Dictionary value)
 {
     ArrayBufferOrArrayBufferViewOrDictionary container;
     container.setDictionary(value);
     return container;
 }
 
-void V8ArrayBufferOrArrayBufferViewOrDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, ArrayBufferOrArrayBufferViewOrDictionary& impl, ExceptionState& exceptionState)
+bool V8ArrayBufferOrArrayBufferViewOrDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, ArrayBufferOrArrayBufferViewOrDictionary& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8ArrayBuffer::hasInstance(v8Value, isolate)) {
         RefPtr<TestArrayBuffer> cppValue = V8ArrayBuffer::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setArrayBuffer(cppValue);
-        return;
+        return true;
     }
 
     if (V8ArrayBufferView::hasInstance(v8Value, isolate)) {
         RefPtr<TestArrayBufferView> cppValue = V8ArrayBufferView::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setArrayBufferView(cppValue);
-        return;
+        return true;
     }
 
     if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(Dictionary, cppValue, Dictionary(v8Value, isolate, exceptionState), exceptionState);
+        Dictionary cppValue = Dictionary(v8Value, isolate, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setDictionary(cppValue);
-        return;
+        return true;
     }
 
     exceptionState.throwTypeError("The provided value is not of type '(ArrayBuffer or ArrayBufferView or Dictionary)'");
+    return false;
 }
 
 v8::Local<v8::Value> toV8(const ArrayBufferOrArrayBufferViewOrDictionary& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case ArrayBufferOrArrayBufferViewOrDictionary::SpecificTypeNone:
         return v8::Null(isolate);
     case ArrayBufferOrArrayBufferViewOrDictionary::SpecificTypeArrayBuffer:
         return toV8(impl.getAsArrayBuffer(), creationContext, isolate);
     case ArrayBufferOrArrayBufferViewOrDictionary::SpecificTypeArrayBufferView:
@@ skipping 71 matching lines @@
     m_type = SpecificTypeUnrestrictedDouble;
 }
 
 BooleanOrStringOrUnrestrictedDouble BooleanOrStringOrUnrestrictedDouble::fromUnrestrictedDouble(double value)
 {
     BooleanOrStringOrUnrestrictedDouble container;
     container.setUnrestrictedDouble(value);
     return container;
 }
 
-void V8BooleanOrStringOrUnrestrictedDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, BooleanOrStringOrUnrestrictedDouble& impl, ExceptionState& exceptionState)
+bool V8BooleanOrStringOrUnrestrictedDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, BooleanOrStringOrUnrestrictedDouble& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (v8Value->IsBoolean()) {
         impl.setBoolean(v8Value->ToBoolean()->Value());
-        return;
+        return true;
     }
 
     if (v8Value->IsNumber()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toDouble(v8Value, exceptionState), exceptionState);
+        double cppValue = toDouble(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setUnrestrictedDouble(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const BooleanOrStringOrUnrestrictedDouble& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case BooleanOrStringOrUnrestrictedDouble::SpecificTypeNone:
         return v8::Null(isolate);
     case BooleanOrStringOrUnrestrictedDouble::SpecificTypeBoolean:
@@ skipping 53 matching lines @@
     m_type = SpecificTypeString;
 }
 
 DoubleOrString DoubleOrString::fromString(String value)
 {
     DoubleOrString container;
     container.setString(value);
     return container;
 }
 
-void V8DoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, DoubleOrString& impl, ExceptionState& exceptionState)
+bool V8DoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, DoubleOrString& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (v8Value->IsNumber()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
+        double cppValue = toRestrictedDouble(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setDouble(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const DoubleOrString& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case DoubleOrString::SpecificTypeNone:
         return v8::Null(isolate);
     case DoubleOrString::SpecificTypeDouble:
@@ skipping 57 matching lines @@
     container.setNodeList(value);
     return container;
 }
 
 void NodeOrNodeList::trace(Visitor* visitor)
 {
     visitor->trace(m_node);
     visitor->trace(m_nodeList);
 }
 
-void V8NodeOrNodeList::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, NodeOrNodeList& impl, ExceptionState& exceptionState)
+bool V8NodeOrNodeList::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, NodeOrNodeList& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8Node::hasInstance(v8Value, isolate)) {
         RefPtrWillBeRawPtr<Node> cppValue = V8Node::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setNode(cppValue);
-        return;
+        return true;
     }
 
     if (V8NodeList::hasInstance(v8Value, isolate)) {
         RefPtrWillBeRawPtr<NodeList> cppValue = V8NodeList::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setNodeList(cppValue);
-        return;
+        return true;
     }
 
     exceptionState.throwTypeError("The provided value is not of type '(Node or NodeList)'");
+    return false;
 }
 
 v8::Local<v8::Value> toV8(const NodeOrNodeList& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case NodeOrNodeList::SpecificTypeNone:
         return v8::Null(isolate);
     case NodeOrNodeList::SpecificTypeNode:
         return toV8(impl.getAsNode(), creationContext, isolate);
     case NodeOrNodeList::SpecificTypeNodeList:
@@ skipping 69 matching lines @@
     m_type = SpecificTypeArrayBufferView;
 }
 
 StringOrArrayBufferOrArrayBufferView StringOrArrayBufferOrArrayBufferView::fromArrayBufferView(PassRefPtr<TestArrayBufferView> value)
 {
     StringOrArrayBufferOrArrayBufferView container;
     container.setArrayBufferView(value);
     return container;
 }
 
-void V8StringOrArrayBufferOrArrayBufferView::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, StringOrArrayBufferOrArrayBufferView& impl, ExceptionState& exceptionState)
+bool V8StringOrArrayBufferOrArrayBufferView::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, StringOrArrayBufferOrArrayBufferView& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8ArrayBuffer::hasInstance(v8Value, isolate)) {
         RefPtr<TestArrayBuffer> cppValue = V8ArrayBuffer::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setArrayBuffer(cppValue);
-        return;
+        return true;
     }
 
     if (V8ArrayBufferView::hasInstance(v8Value, isolate)) {
         RefPtr<TestArrayBufferView> cppValue = V8ArrayBufferView::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setArrayBufferView(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const StringOrArrayBufferOrArrayBufferView& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case StringOrArrayBufferOrArrayBufferView::SpecificTypeNone:
         return v8::Null(isolate);
     case StringOrArrayBufferOrArrayBufferView::SpecificTypeString:
@@ skipping 53 matching lines @@
     m_type = SpecificTypeDouble;
 }
 
 StringOrDouble StringOrDouble::fromDouble(double value)
 {
     StringOrDouble container;
     container.setDouble(value);
     return container;
 }
 
-void V8StringOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, StringOrDouble& impl, ExceptionState& exceptionState)
+bool V8StringOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, StringOrDouble& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (v8Value->IsNumber()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
+        double cppValue = toRestrictedDouble(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setDouble(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const StringOrDouble& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case StringOrDouble::SpecificTypeNone:
         return v8::Null(isolate);
     case StringOrDouble::SpecificTypeString:
@@ skipping 51 matching lines @@
     m_type = SpecificTypeStringSequence;
 }
 
 StringOrStringSequence StringOrStringSequence::fromStringSequence(const Vector<String>& value)
 {
     StringOrStringSequence container;
     container.setStringSequence(value);
     return container;
 }
 
-void V8StringOrStringSequence::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, StringOrStringSequence& impl, ExceptionState& exceptionState)
+bool V8StringOrStringSequence::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, StringOrStringSequence& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (v8Value->IsArray()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(Vector<String>, cppValue, toImplArray<String>(v8Value, 0, isolate, exceptionState), exceptionState);
+        Vector<String> cppValue = toImplArray<String>(v8Value, 0, isolate, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setStringSequence(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const StringOrStringSequence& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case StringOrStringSequence::SpecificTypeNone:
         return v8::Null(isolate);
     case StringOrStringSequence::SpecificTypeString:
@@ skipping 56 matching lines @@
     m_type = SpecificTypeDouble;
 }
 
 TestEnumOrDouble TestEnumOrDouble::fromDouble(double value)
 {
     TestEnumOrDouble container;
     container.setDouble(value);
     return container;
 }
 
-void V8TestEnumOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestEnumOrDouble& impl, ExceptionState& exceptionState)
+bool V8TestEnumOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestEnumOrDouble& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (v8Value->IsNumber()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
+        double cppValue = toRestrictedDouble(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setDouble(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))

[haraken, 2015/02/24 12:44:57]

Would it be possible to write this like:

  V8StringResource<> cppValue = toV8StringResource(v8value, exceptionState);
  if (exceptionState.hadException())
    return false;

for consistency with other toXXX conversions?

[Jens Widell, 2015/02/24 13:36:07]

It would. But do you mean only this form of prepare() that already uses an
ExceptionState, or both?

There is a slight optimization (although I haven't verified to what degree it
is) in the other form of prepare() in that it doesn't have a v8::TryCatch, and
thus in practice just returns whether there's a scheduled exception in V8,
without extracting that exception from V8.

+            return false;
         String string = cppValue;
         if (!(string == "" || string == "EnumValue1" || string == "EnumValue2" || string == "EnumValue3")) {
             exceptionState.throwTypeError("'" + string + "' is not a valid enum value.");
-            return;
+            return false;
         }
         impl.setTestEnum(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const TestEnumOrDouble& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case TestEnumOrDouble::SpecificTypeNone:
         return v8::Null(isolate);
     case TestEnumOrDouble::SpecificTypeTestEnum:
@@ skipping 51 matching lines @@
     m_type = SpecificTypeUint8Array;
 }
 
 TestInterface2OrUint8Array TestInterface2OrUint8Array::fromUint8Array(PassRefPtr<DOMUint8Array> value)
 {
     TestInterface2OrUint8Array container;
     container.setUint8Array(value);
     return container;
 }
 
-void V8TestInterface2OrUint8Array::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterface2OrUint8Array& impl, ExceptionState& exceptionState)
+bool V8TestInterface2OrUint8Array::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterface2OrUint8Array& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8TestInterface2::hasInstance(v8Value, isolate)) {
         RefPtr<TestInterface2> cppValue = V8TestInterface2::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setTestInterface2(cppValue);
-        return;
+        return true;
     }
 
     if (V8Uint8Array::hasInstance(v8Value, isolate)) {
         RefPtr<DOMUint8Array> cppValue = V8Uint8Array::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setUint8Array(cppValue);
-        return;
+        return true;
     }
 
     exceptionState.throwTypeError("The provided value is not of type '(TestInterface2 or Uint8Array)'");
+    return false;
 }
 
 v8::Local<v8::Value> toV8(const TestInterface2OrUint8Array& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case TestInterface2OrUint8Array::SpecificTypeNone:
         return v8::Null(isolate);
     case TestInterface2OrUint8Array::SpecificTypeTestInterface2:
         return toV8(impl.getAsTestInterface2(), creationContext, isolate);
     case TestInterface2OrUint8Array::SpecificTypeUint8Array:
@@ skipping 54 matching lines @@
     TestInterfaceGarbageCollectedOrString container;
     container.setString(value);
     return container;
 }
 
 void TestInterfaceGarbageCollectedOrString::trace(Visitor* visitor)
 {
     visitor->trace(m_testInterfaceGarbageCollected);
 }
 
-void V8TestInterfaceGarbageCollectedOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceGarbageCollectedOrString& impl, ExceptionState& exceptionState)
+bool V8TestInterfaceGarbageCollectedOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceGarbageCollectedOrString& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8TestInterfaceGarbageCollected::hasInstance(v8Value, isolate)) {
         RawPtr<TestInterfaceGarbageCollected> cppValue = V8TestInterfaceGarbageCollected::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setTestInterfaceGarbageCollected(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const TestInterfaceGarbageCollectedOrString& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case TestInterfaceGarbageCollectedOrString::SpecificTypeNone:
         return v8::Null(isolate);
     case TestInterfaceGarbageCollectedOrString::SpecificTypeTestInterfaceGarbageCollected:
@@ skipping 51 matching lines @@
     m_type = SpecificTypeLong;
 }
 
 TestInterfaceOrLong TestInterfaceOrLong::fromLong(int value)
 {
     TestInterfaceOrLong container;
     container.setLong(value);
     return container;
 }
 
-void V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceOrLong& impl, ExceptionState& exceptionState)
+bool V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceOrLong& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8TestInterface::hasInstance(v8Value, isolate)) {
         RefPtr<TestInterfaceImplementation> cppValue = V8TestInterface::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setTestInterface(cppValue);
-        return;
+        return true;
     }
 
     if (v8Value->IsNumber()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
+        int cppValue = toInt32(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setLong(cppValue);
-        return;
+        return true;
     }
 
     {
-        TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
+        int cppValue = toInt32(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setLong(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const TestInterfaceOrLong& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case TestInterfaceOrLong::SpecificTypeNone:
         return v8::Null(isolate);
     case TestInterfaceOrLong::SpecificTypeTestInterface:
@@ skipping 51 matching lines @@
     m_type = SpecificTypeTestInterfaceEmpty;
 }
 
 TestInterfaceOrTestInterfaceEmpty TestInterfaceOrTestInterfaceEmpty::fromTestInterfaceEmpty(PassRefPtr<TestInterfaceEmpty> value)
 {
     TestInterfaceOrTestInterfaceEmpty container;
     container.setTestInterfaceEmpty(value);
     return container;
 }
 
-void V8TestInterfaceOrTestInterfaceEmpty::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceOrTestInterfaceEmpty& impl, ExceptionState& exceptionState)
+bool V8TestInterfaceOrTestInterfaceEmpty::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceOrTestInterfaceEmpty& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8TestInterface::hasInstance(v8Value, isolate)) {
         RefPtr<TestInterfaceImplementation> cppValue = V8TestInterface::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setTestInterface(cppValue);
-        return;
+        return true;
     }
 
     if (V8TestInterfaceEmpty::hasInstance(v8Value, isolate)) {
         RefPtr<TestInterfaceEmpty> cppValue = V8TestInterfaceEmpty::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setTestInterfaceEmpty(cppValue);
-        return;
+        return true;
     }
 
     exceptionState.throwTypeError("The provided value is not of type '(TestInterface or TestInterfaceEmpty)'");
+    return false;
 }
 
 v8::Local<v8::Value> toV8(const TestInterfaceOrTestInterfaceEmpty& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case TestInterfaceOrTestInterfaceEmpty::SpecificTypeNone:
         return v8::Null(isolate);
     case TestInterfaceOrTestInterfaceEmpty::SpecificTypeTestInterface:
         return toV8(impl.getAsTestInterface(), creationContext, isolate);
     case TestInterfaceOrTestInterfaceEmpty::SpecificTypeTestInterfaceEmpty:
@@ skipping 55 matching lines @@
     container.setTestDictionary(value);
     return container;
 }
 
 void TestInterfaceWillBeGarbageCollectedOrTestDictionary::trace(Visitor* visitor)
 {
     visitor->trace(m_testInterfaceWillBeGarbageCollected);
     visitor->trace(m_testDictionary);
 }
 
-void V8TestInterfaceWillBeGarbageCollectedOrTestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceWillBeGarbageCollectedOrTestDictionary& impl, ExceptionState& exceptionState)
+bool V8TestInterfaceWillBeGarbageCollectedOrTestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestInterfaceWillBeGarbageCollectedOrTestDictionary& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (V8TestInterfaceWillBeGarbageCollected::hasInstance(v8Value, isolate)) {
         RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> cppValue = V8TestInterfaceWillBeGarbageCollected::toImpl(v8::Local<v8::Object>::Cast(v8Value));
         impl.setTestInterfaceWillBeGarbageCollected(cppValue);
-        return;
+        return true;
     }
 
     if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {
         TestDictionary cppValue;
-        TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL(V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState), exceptionState);
+        TestDictionary cppValue;
+        if (!V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState))
+            return false;
         impl.setTestDictionary(cppValue);
-        return;
+        return true;
     }
 
     exceptionState.throwTypeError("The provided value is not of type '(TestInterfaceWillBeGarbageCollected or TestDictionary)'");
+    return false;
 }
 
 v8::Local<v8::Value> toV8(const TestInterfaceWillBeGarbageCollectedOrTestDictionary& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case TestInterfaceWillBeGarbageCollectedOrTestDictionary::SpecificTypeNone:
         return v8::Null(isolate);
     case TestInterfaceWillBeGarbageCollectedOrTestDictionary::SpecificTypeTestInterfaceWillBeGarbageCollected:
         return toV8(impl.getAsTestInterfaceWillBeGarbageCollected(), creationContext, isolate);
     case TestInterfaceWillBeGarbageCollectedOrTestDictionary::SpecificTypeTestDictionary:
@@ skipping 49 matching lines @@
     m_type = SpecificTypeString;
 }
 
 UnrestrictedDoubleOrString UnrestrictedDoubleOrString::fromString(String value)
 {
     UnrestrictedDoubleOrString container;
     container.setString(value);
     return container;
 }
 
-void V8UnrestrictedDoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, UnrestrictedDoubleOrString& impl, ExceptionState& exceptionState)
+bool V8UnrestrictedDoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, UnrestrictedDoubleOrString& impl, ExceptionState& exceptionState)
 {
     if (v8Value.IsEmpty())
-        return;
+        return true;
 
     if (v8Value->IsNumber()) {
-        TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toDouble(v8Value, exceptionState), exceptionState);
+        double cppValue = toDouble(v8Value, exceptionState);
+        if (exceptionState.hadException())
+            return false;
         impl.setUnrestrictedDouble(cppValue);
-        return;
+        return true;
     }
 
     {
-        TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, v8Value, exceptionState);
+        V8StringResource<> cppValue = v8Value;
+        if (!cppValue.prepare(exceptionState))
+            return false;
         impl.setString(cppValue);
-        return;
+        return true;
     }
 
 }
 
 v8::Local<v8::Value> toV8(const UnrestrictedDoubleOrString& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
 {
     switch (impl.m_type) {
     case UnrestrictedDoubleOrString::SpecificTypeNone:
         return v8::Null(isolate);
     case UnrestrictedDoubleOrString::SpecificTypeUnrestrictedDouble:
         return v8::Number::New(isolate, impl.getAsUnrestrictedDouble());
     case UnrestrictedDoubleOrString::SpecificTypeString:
         return v8String(isolate, impl.getAsString());
     default:
         ASSERT_NOT_REACHED();
     }
     return v8::Local<v8::Value>();
 }
 
 UnrestrictedDoubleOrString NativeValueTraits<UnrestrictedDoubleOrString>::nativeValue(const v8::Local<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
 {
     UnrestrictedDoubleOrString impl;
     V8UnrestrictedDoubleOrString::toImpl(isolate, value, impl, exceptionState);
     return impl;
 }
 
 } // namespace blink